kmd_driver_t: reject Windows multi-GPU configuration at attach time#8917
Open
czidev-amd wants to merge 1 commit into
Open
kmd_driver_t: reject Windows multi-GPU configuration at attach time#8917czidev-amd wants to merge 1 commit into
czidev-amd wants to merge 1 commit into
Conversation
Multi-GPU configurations on Windows are a documented known limitation of the HIP SDK Debugger. Rather than crash mid-session with an opaque fatal_error_t, detect the unsupported topology at the earliest opportunity (check_version(), called before enable_debug() and any GPU interaction) and return AMD_DBGAPI_STATUS_ERROR_RESTRICTION with a clear diagnostic. ROCgdb already handles ERROR_RESTRICTION gracefully: it emits a warning and continues with CPU-only debugging. Fixes: ROCM-9233 Signed-off-by: Claudiu Zissulescu <claudiu.zissulescu-ianculescu@amd.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
lumachad
reviewed
Jul 21, 2026
lumachad
left a comment
lumachad
left a comment
Contributor
There was a problem hiding this comment.
Just a nit. Looks reasonable to me otherwise.
| if (m_agents.size () > 1) | ||
| { | ||
| warning ("GPU debugging on Windows supports only a single AMD GPU " | ||
| "debug agent; %zu agents were detected. GPU debugging will " |
Contributor
There was a problem hiding this comment.
Reads odd with the "debug agent; break". I'm not sure if that's was intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-GPU configurations on Windows are a documented known limitation of the HIP SDK Debugger. Rather than crash mid-session with an opaque fatal_error_t, detect the unsupported topology at the earliest opportunity (check_version(), called before enable_debug() and any GPU interaction) and return AMD_DBGAPI_STATUS_ERROR_RESTRICTION with a clear diagnostic.
ROCgdb already handles ERROR_RESTRICTION gracefully: it emits a warning and continues with CPU-only debugging.
Fixes: ROCM-9233