fix(rocprof-trace-decoder): handle and table lifetime after main#8903
Open
ApoKalipse-V wants to merge 2 commits into
Open
fix(rocprof-trace-decoder): handle and table lifetime after main#8903ApoKalipse-V wants to merge 2 commits into
ApoKalipse-V wants to merge 2 commits into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
ApoKalipse-V
changed the title
ApoKalipse-V
force-pushed
the
users/gbaraldi/fixlifetime
branch
from
July 21, 2026 01:07
905f4ff to
125853b
Compare
ApoKalipse-V
force-pushed
the
users/gbaraldi/fixlifetime
branch
from
July 21, 2026 10:51
125853b to
0b72b4d
Compare
meserve-amd
approved these changes
Jul 21, 2026
meserve-amd
left a comment
meserve-amd
left a comment
Contributor
There was a problem hiding this comment.
Looks good and I like the test. Some minor comments on convention and naming.
ApoKalipse-V
force-pushed
the
users/gbaraldi/fixlifetime
branch
from
July 21, 2026 16:47
0b72b4d to
a6c39f5
Compare
ApoKalipse-V
added
ready to merge
and removed
Not ready to Review
ready for peer review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rocprof-trace-decoder does not handle well functions called both before/after main() due to lifetime issues of static objects.
This PR addresses it.
JIRA ID : AIPROFSDK-1001
Submission Checklist