Skip to content

[ci] Extend/dedup path filters in therock_configure_ci.py#8893

Merged
ScottTodd merged 2 commits into
users/scotttodd/therock-ci-unit-testsfrom
users/scotttodd/configure-ci-filters
Jul 22, 2026
Merged

[ci] Extend/dedup path filters in therock_configure_ci.py#8893
ScottTodd merged 2 commits into
users/scotttodd/therock-ci-unit-testsfrom
users/scotttodd/configure-ci-filters

Conversation

@ScottTodd

Copy link
Copy Markdown
Member

Motivation

The SKIPPABLE_PATH_PATTERNS list that controls which paths can be modified without triggering the full "TheRock CI" workflows had a few overlapping patterns like *.gitignore and projects/*/.gitignore and was missing patterns for some newly added directories like tools/systems_pr_bot/* (see #7842).

Technical Details

I (well, with some nudging by Codex) decided to also restructure the test_is_path_skippable test case to make new subtests easier to add.

Test Plan

New + existing unit tests (now running/passing thanks to #8882)

Submission Checklist

Cover concrete nested path matches and ensure unrelated GitHub actions are skipped while TheRock actions still trigger CI.

Assisted-by: OpenAI Codex
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Jul 20, 2026
@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@ScottTodd
ScottTodd requested a review from geomin12 July 20, 2026 22:47
@ScottTodd
ScottTodd marked this pull request as ready for review July 20, 2026 23:06
@ScottTodd
ScottTodd requested a review from a team as a code owner July 20, 2026 23:06
@ScottTodd

Copy link
Copy Markdown
Member Author

I'm trying out stacked PRs here FYI: https://github.github.com/gh-stack/. Not sure how that will handle it if I merge the base PR first. I might be able to merge the stack together using squash and merge 🤔

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks! this will help, but sooooooon to multi-arch so we don't need to deal with these files

@geomin12

Copy link
Copy Markdown
Contributor

I'm trying out stacked PRs here FYI: https://github.github.com/gh-stack/. Not sure how that will handle it if I merge the base PR first. I might be able to merge the stack together using squash and merge 🤔

woah this is cool

@ScottTodd

Copy link
Copy Markdown
Member Author

but sooooooon to multi-arch so we don't need to deal with these files

is there a different file that will be used to determine when multi-arch CI should run for changes in rocm-systems?

@ScottTodd
ScottTodd disabled auto-merge July 22, 2026 14:37
@ScottTodd
ScottTodd merged commit 53460c3 into develop Jul 22, 2026
76 of 96 checks passed
@ScottTodd
ScottTodd deleted the users/scotttodd/configure-ci-filters branch July 22, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants