docs(amdsmi): correct 7.14.0 changelog and move items to 7.15.0#8886
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
marifamd
changed the title
marifamd
changed the title
gabrpham
approved these changes
Jul 21, 2026
- Merge the redundant `### Fixed` block into `### Resolved Issues` so the 7.14.0 release uses the same heading set as every other release - Remove the `(ROCM-21057)` ticket reference from a 7.13.0 headline and add the trailing double-space for the Sphinx hard break Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
- Determine the 7.14 release point from the rocm-systems submodule commit pinned by the therock-7.14 tag (2b22ab0, 2026-07-09) - Move the three process-visibility / table-alignment bullets (PR #8396, merged 2026-07-16, after the pin) into a new 7.15.0 Resolved Issues section; they were incorrectly filed under 7.14.0 - Document the TheRock-pin release-attribution method in the amdsmi-changelog-automation skill so entries land in the right release Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
- Replace stale [Unreleased]/Fixed references with the repo's real section set (Added/Changed/Removed/Optimized/Resolved Issues/Upcoming Changes) - Route bug fixes to Resolved Issues, deprecations to Upcoming Changes, and perf/tooling to Optimized in the required-entry table and example Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
- Frame a release's changelog as the diff between two consecutive ROCm release pins (PREV_PIN..CURR_PIN) instead of hard-coding 7.14/7.15 - Resolve both bracketing pins dynamically; fall back to origin/develop as the upper bound while the current release is untagged - Keep the merge-base --is-ancestor check for classifying PR-history commits; drop the 'iff' wording Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Bound each section by its own TheRock pin (drop the patch component) and check both range bounds so entries merged after a release's pin are flagged TOO NEW, not silently passed. Make pin() tolerate lookup errors, auto-derive the section line range, add a heading-taxonomy check, and cut the redundant review-checklist and severity tables. 166 -> 101 lines. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
The IFoE/UALoE lazy-init fix merged to develop after the 7.14.0 pin, so its changelog entry landed under 7.14.0. Move it into the 7.15.0 Resolved Issues section where post-pin fixes belong. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
marifamd
force-pushed
the
changelog-714-fix
branch
from
July 21, 2026 05:28
4a04d0f to
7526436
Compare
adam360x
approved these changes
Jul 21, 2026
cmcknigh
pushed a commit
that referenced
this pull request
Jul 22, 2026
- Move the IFoE/UALoE lazy-init fix entry from 7.14.0 to the 7.15.0 Resolved Issues section, since it merged after the 7.14.0 pin - Keep 7.14.0 limited to entries that shipped in that release --------- Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two problems in the 7.14.0 changelog block:
rocm-systemsat2b22ab0(via thetherock-7.14tag, dated 2026-07-09), so those fixes belong in 7.15.0.(ROCM-21057)JIRA reference in a 7.13.0 headline, which was also missing the Sphinx hard-break trailing spaces.Technical Details
Changelog (
CHANGELOG.md):## amd_smi_lib for ROCm 7.15.0section at the top with a### Resolved Issuesblock holding the three PR fix(amdsmi): process visibility, per-GPU attribution, table alignment #8396 process/table-alignment bullets### Fixedheading from 7.14.0 (7.14.0 keeps the Added/Changed/Removed/Resolved-Issues layout of prior releases)(ROCM-21057)ticket reference from the gfx1151 idle-clock headline and add the trailing double-space for the Sphinx hard breakSkill (
.claude/skills/amdsmi-changelog-automation/SKILL.md):rocm-systemssubmodule commit pinned by the matchingtherock-<ver>TheRock release, then classify each entry's commit withgit merge-base --is-ancestoragainst that pin. Anything after the pin moves to the next release.JIRA ID
N/A (changelog cleanup)
Test Plan
gh api repos/ROCm/TheRock/git/trees/therock-7.14→rocm-systems=2b22ab0git merge-base --is-ancestor <commit> 2b22ab0— only PR fix(amdsmi): process visibility, per-GPU attribution, table alignment #8396 (d7fc3d2) is after the pingrep -nP '^- \*\*.*\*\*[^ ]*$' CHANGELOG.md— no bolded headline missing the trailing double-spacegrep -nE 'ROCM-[0-9]+|SWDEV-[0-9]+|AILITOOLS-[0-9]+' CHANGELOG.md— no ticket refs remainTest Result
d7fc3d2(PR fix(amdsmi): process visibility, per-GPU attribution, table alignment #8396) classified as after-pin; its three bullets now sit under 7.15.0.Submission Checklist