Add SQTT marker support to rocSHMEM to improve device-level performance tracing#8176
Add SQTT marker support to rocSHMEM to improve device-level performance tracing#8176mberenjk wants to merge 1 commit into
Conversation
adding sqtt_enabled flag to hipcc Adding sqtt_marker to different section of the code
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
Is the switch case itself a performance concern?
If not, I'd recommend to have just enter post_wqe_rma here
(it can be if gda_provider_ can be slow to load)
There was a problem hiding this comment.
Would it be useful if we provided a way for enter/exit to contain extra information? E.g.
sqtt_marker_enter("mymarker")
if (a)
sqtt_marker_exit("mymarker", "A")
else
sqtt_marker_exit("mymarker", "B")
There was a problem hiding this comment.
I think you need a flag here to switch these off when needed, like you do in #ifdef ENABLE_ROCTX
Imagine we changed the path, or sqtt_trace.hpp wasn't available for some reason
There was a problem hiding this comment.
We plan on having this available globally in rocm soon. I dont think it hurts for now, though.
There was a problem hiding this comment.
Doesn't hurt, but it's off by default.
Motivation
Adding sqtt_marker to device functions and critical sections of the code to mprove device-level performance tracing
Technical Details
Add SQTT marker support to rocSHMEM to enable device-side performance tracing. Similar to ROCTX, this provides annotations for performance analysis, but unlike ROCTX, it works on the device side, allowing correlation of rocSHMEM operations directly with GPU execution. This will improve trace visibility and help identify kernel-level bottlenecks more effectively.
JIRA ID
AIROCSHMEM-431
Test Plan
A complete test will be added in the CI with rocprofiler-sdk
Test Result
Submission Checklist