Resolves: #1182#9989
Open
AlexVlx wants to merge 1 commit into
Open
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hipstd::Stack_accessor::touch_stack_causes segfault when stack size is "unlimited"Technical Details
Due to how HMM works, we have to pre-touch the stack before advising via
AccesedBy. With unlimited stacks, the stack size isUINT64_MAX, so the touch loops ends up walking past the end of actual memory. We fix it by capping the "unlimited" case toPTHREAD_STACK_MIN. An alternative would be to walk the entirety of process addressable memory, but this would be expensive, and probably lead to other issues.Test Plan
Already covered.
Test Result
Great success.