Skip to content

Resolves: #1182#9989

Open
AlexVlx wants to merge 1 commit into
ROCm:developfrom
AlexVlx:users/AlexVlx/fix_stack_accessor
Open

Resolves: #1182#9989
AlexVlx wants to merge 1 commit into
ROCm:developfrom
AlexVlx:users/AlexVlx/fix_stack_accessor

Conversation

@AlexVlx

@AlexVlx AlexVlx commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Motivation

hipstd::Stack_accessor::touch_stack_ causes segfault when stack size is "unlimited"

Technical Details

Due to how HMM works, we have to pre-touch the stack before advising via AccesedBy. With unlimited stacks, the stack size is UINT64_MAX, so the touch loops ends up walking past the end of actual memory. We fix it by capping the "unlimited" case to PTHREAD_STACK_MIN. An alternative would be to walk the entirety of process addressable memory, but this would be expensive, and probably lead to other issues.

Test Plan

Already covered.

Test Result

Great success.

@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocthrust/thrust/system/hip/hipstdpar/impl/interpose_allocations_v1.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant