Skip to content

Install pdb files#288

Merged
pfultz2 merged 2 commits into
developfrom
install-pdb-files
Jun 29, 2026
Merged

Install pdb files#288
pfultz2 merged 2 commits into
developfrom
install-pdb-files

Conversation

@pfultz2

@pfultz2 pfultz2 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@pfultz2 pfultz2 requested review from cgmb and lawruble13 as code owners June 24, 2026 14:24
@ivarusic-amd

ivarusic-amd commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@pfultz2 I think, Windows CI fails because $<TARGET_PDB_FILE:...> is only supported by MSVC-compatible toolchains
Two CI configurations hit this error:

  1. Ninja + clang++
  2. Ninja + default - on the GitHub runner, Ninja picks up MinGW/GCC from PATH
    Both of those does not produce PDB files (at least will not work with <TARGET_PDB_FILE:...>) .

To fix this we need an MSVC guard around the TARGET_PDB_FILE usage, so PDB installation is skipped for compilers that
can't produce them.

Additionally, we can update the CI to use MSVC-compatible compilers for all Windows jobs: switch clang++ to clang-cl
and add msvc-dev-cmd so Ninja finds MSVC instead of MinGW. This way all Windows CI configurations actually test PDB
installation rather than just skipping it.

@ivarusic-amd

Copy link
Copy Markdown
Contributor

I've tested this in draft PR here: #290

@ivarusic-amd

Copy link
Copy Markdown
Contributor

MSVC flag is not enough;

 if(WIN32 AND
            (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC" OR
             CMAKE_C_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC") AND

@pfultz2 pfultz2 enabled auto-merge (squash) June 29, 2026 17:07
@pfultz2 pfultz2 disabled auto-merge June 29, 2026 17:07
@pfultz2 pfultz2 merged commit c835e73 into develop Jun 29, 2026
19 checks passed
@pfultz2 pfultz2 deleted the install-pdb-files branch June 29, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants