Update README instructions for newer ROCm#496
Open
daniellegillai wants to merge 8 commits into
Open
Conversation
daniellegillai
requested review from
a team,
kiritigowda and
rrawther
as code owners
July 23, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current README's installation instructions are out of date for newer versions of ROCm, in which the ROCm Core SDK provides many of the required libraries, rather than needing to install them separately as packages. This change reorganizes the README into two different installation sections, one for the older ROCm, following a package install approach, and one for newer ROCm, following a source install approach.
Technical Details
Reorganized installation instructions to support both ROCm versions:
For ROCm 7.13+: Added source build instructions. RPP and other media libraries (rocDecode, rocJPEG, HIP, half) are provided by the ROCm Core SDK and do not need separate installation. Only MIVisionX requires manual building from source.
For ROCm 7.2.x and below: Package install instructions are mostly unchanged.
Also added pkg-config, protobuf-compiler, libjpeg-dev as dependencies, as they were required for building successfully when tested on the Docker container.
Does not currently include instructions for building RPP from source, under the assumption that RPP will get into the rock soon.
Test Plan
Followed the build from source instructions on a Docker container with ROCm 7.15 installed (mivisionx/ubuntu-24.04:rocm-20260710) and ran CTests (did not test pybindings).
Test Result
CTests all passed.
Submission Checklist