Remove remaining OpenCL #486
Merged
Merged
Conversation
daniellegillai
requested review from
a team,
kiritigowda and
rrawther
as code owners
July 10, 2026 18:52
rrawther
requested changes
Jul 14, 2026
rrawther
left a comment
Collaborator
There was a problem hiding this comment.
device_data_transfer_code.h might be used for HIP backend. Please check
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the removal of deprecated OpenCL backend support from rocAL by deleting OpenCL-specific code paths, updating memory-type conditionals to be HIP-only for GPU flows, and removing OpenCL-facing build/setup/documentation references.
Changes:
- Removed
RocalMemType::OCLand updated GPU/host branching to treat HIP as the only GPU backend. - Deleted OpenCL-specific utilities (e.g., OpenCL transfer kernels, OpenCL CMake finder, and related macros) and removed OpenCL backend build logic.
- Updated user-facing setup/help text and docs to remove OpenCL instructions/options.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rocAL/source/pipeline/tensor.cpp | Removes OpenCL memory mapping in vx_mem_type(). |
| rocAL/source/pipeline/ring_buffer.cpp | Updates buffer-selection and metadata checks to treat HIP as the only GPU path. |
| rocAL/source/pipeline/master_graph.cpp | Removes OpenCL macro and updates GPU-affinity checks from OCL/HIP to HIP only. |
| rocAL/source/loaders/video/video_loader.cpp | Updates loader output handling to treat HIP as the only GPU backend. |
| rocAL/source/loaders/image/numpy_loader.cpp | Updates tensor update path to treat HIP as the only GPU backend. |
| rocAL/source/loaders/image/image_loader.cpp | Updates image update path to treat HIP as the only GPU backend. |
| rocAL/source/loaders/image/cifar10_loader.cpp | Updates CIFAR10 loader output handling to treat HIP as the only GPU backend. |
| rocAL/source/loaders/audio/audio_loader.cpp | Updates audio update path to treat HIP as the only GPU backend. |
| rocAL/include/pipeline/tensor.h | Updates comments related to memory type/handles after OpenCL removal. |
| rocAL/include/pipeline/commons.h | Removes OCL from RocalMemType and updates related documentation. |
| rocAL/include/device/device_data_transfer_code.h | Deletes OpenCL data transfer kernels/utilities. |
| rocAL/CMakeLists.txt | Removes OpenCL backend build logic and OpenCL-related checks. |
| rocAL-setup.py | Removes OCL backend option and OpenCL ICD install logic. |
| README.md | Removes OpenCL backend instructions and updates backend options in setup usage. |
| docs/install/rocAL-prerequisites.rst | Updates documented setup options to HIP/CPU only. |
| CMakeLists.txt | Updates printed backend options to remove OPENCL. |
| cmake/FindOpenCL.cmake | Removes custom OpenCL finder module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@daniellegillai please address copilot review |
rrawther
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenCL is deprecated in rocAL, but there were still remaining references to it in the README and checks in the code.
Technical Details
Removed OpenCL backend support:
OCL || HIPtoHIPonlyTest Plan
rocAL ctests.
Test Result
When in addition to this PR, PR #485 is also applied in order to fix issue #484, all 21 ctests pass.
Submission Checklist