Fix rocDecode test

[daniellegillai]

Motivation

Fixes #479 so that the video_tests_rocdecode ctest passes.

Technical Details

Pass in 1 as the hardware_decode_mode arg for video_tests.cpp (instead of 2), and also change video_tests.cpp to consistently check if the decoder_type == 1, rather than == 1 in one check and > 0 in another.

Test Plan

rocAL ctests.

Test Result

All 21 ctests pass.

[Copilot]

Pull request overview

Fixes the failing video_tests_rocdecode CTest by aligning the test arguments and decoder selection logic with the documented hardware_decode_mode=0/1 contract, preventing mismatched decode configuration that could lead to hangs/timeouts.

Changes:

• Update video_tests_rocdecode CTest to pass hardware_decode_mode=1 (valid value) instead of 2.
• Make video_tests.cpp consistently treat decoder_type == 1 as the only condition for HW/rocDecode mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/cpp_api/video_tests/video_tests.cpp	Makes HW decode mode selection consistent by checking decoder_type == 1.
tests/cpp_api/CMakeLists.txt	Fixes the rocDecode CTest argument to use a valid hardware_decode_mode value.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rrawther]

please address copilot comment as well

[daniellegillai]

Right now the CI is not running the rocDecode tests (-DCMAKE_DISABLE_FIND_PACKAGE_rocdecode=ON), as otherwise there is the follow cmake error:

CMake Error at rocAL/CMakeLists.txt:281 (add_library):
  Cannot find source file:
    /opt/rocm/share/rocdecode/utils/rocvideodecode/roc_video_dec.cpp

CMake Error at rocAL/rocAL_hip/CMakeLists.txt:50 (add_library):
  Cannot find source file:
    /opt/rocm/share/rocdecode/utils/resize_kernels.cpp

The /opt/rocm/share/rocdecode/utils directory does not exist in the docker image used in the CI.

[daniellegillai]

Right now the CI is not running the rocDecode tests (-DCMAKE_DISABLE_FIND_PACKAGE_rocdecode=ON), as otherwise there is the follow cmake error:

CMake Error at rocAL/CMakeLists.txt:281 (add_library):
  Cannot find source file:
    /opt/rocm/share/rocdecode/utils/rocvideodecode/roc_video_dec.cpp

CMake Error at rocAL/rocAL_hip/CMakeLists.txt:50 (add_library):
  Cannot find source file:
    /opt/rocm/share/rocdecode/utils/resize_kernels.cpp

The /opt/rocm/share/rocdecode/utils directory does not exist in the docker image used in the CI.

Having the CI build rocDecode from source solves this problem and provides the required source files in the /opt/rocm/share/rocdecode/utils directory.

[daniellegillai]

rocDecode test now enabled and succeeding on the workflow when tested locally (48a2e47)

[rrawther]

Added a comment