Chrome trace format support#949
Open
vstempen wants to merge 6 commits into
Open
Conversation
vstempen
requested review from
a team,
Sajeeth-Wimalasuriyan,
amokiche-amd,
drchen-amd and
tomk-amd
as code owners
July 22, 2026 17:43
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| query += group; | ||
| if(sample_query) | ||
| YAML::Node config = YAML::LoadFile(filename); |
| } | ||
|
|
||
| void PackedTable::AggregateRow(ProfileDatabase* db, int row_index, int map_index) | ||
| void PackedTable::AggregateRow(QueryManager* db, int row_index, int map_index) |
|
|
||
|
|
||
| rocprofvis_dm_result_t | ||
| QueryManager::BuildTableQuery( |
Comment on lines
+794
to
+797
| { | ||
| result = kRocProfVisDmResultUnknownError; | ||
| ROCPROFVIS_ASSERT_MSG_BREAK(false, ex.what()); | ||
| } |
Comment on lines
+844
to
+852
| { | ||
| // The worker thread never started, so the sub-future's promise will | ||
| // never be set; unregister and free it now to avoid a wait below | ||
| // that would block forever on an unfulfilled promise. | ||
| parent->DeleteSubFuture(futures[i]); | ||
| futures[i] = nullptr; | ||
| result = kRocProfVisDmResultUnknownError; | ||
| ROCPROFVIS_ASSERT_MSG_BREAK(false, ex.what()); | ||
| } |
|
|
||
|
|
||
| int RocpdDatabase::ProcessTrack(rocprofvis_dm_track_params_t& track_params, rocprofvis_dm_charptr_t* newqueries) | ||
| int RocpdDatabase::ProcessTrack(rocprofvis_dm_track_params_t& track_params, std::vector<rocprofvis_dm_string_t> & newqueries) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make a working pilot of Perfetto trace formats support. It shows number of efforts on both sides (rorOptiq and potentially profiler hub) to support new format, rocOptic data model ability to ingest another format/schema adapter, controller and UI ability to handle missing data (mostly regarding topology implementation), etc.
Technical Details
In the initial commit the code will fail to build without Perfetto trace processor libraries prebuilt.
Will try to add flexibility to skip the support in following commits.
Here are the libraries build instructions : Building Perfetto Libraries.
After libraries have been built, build the project and try to open Pytorch traces or any other Perfetto traces in .json, .proto or .pftrace formats.
Also, in coming commits will reduce number of files. Those can be copied dynamically during build. Don't have to be submitted