Store SSH secrets in the OS credential vault instead of plaintext#940
Open
Sajeeth-Wimalasuriyan wants to merge 1 commit into
Open
Store SSH secrets in the OS credential vault instead of plaintext#940Sajeeth-Wimalasuriyan wants to merge 1 commit into
Sajeeth-Wimalasuriyan wants to merge 1 commit into
Conversation
Add SecretStore, a small wrapper over the OS credential store (Windows Credential Manager, macOS Keychain, libsecret on Linux). SSH passwords and key passphrases now live there, keyed by the connection id, and are no longer written to profiles.json. SshConnectionStore moves secrets in/out of the vault on load/save/remove. Legacy plaintext left by older builds is ignored (the user re-enters on connect) and stripped from disk on load. When no vault is available, secrets are not persisted and the SSH layer prompts at connect time. Co-authored-by: Cursor <cursoragent@cursor.com>
Sajeeth-Wimalasuriyan
requested review from
a team,
amokiche-amd,
drchen-amd and
tomk-amd
as code owners
July 17, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SecretStore, a small wrapper over the OS credential store (Windows Credential Manager, macOS Keychain, libsecret on Linux). SSH passwords and key passphrases now live there, keyed by the connection id, and are no longer written to profiles.json.
SshConnectionStore moves secrets in/out of the vault on load/save/remove. Legacy plaintext left by older builds is ignored (the user re-enters on connect) and stripped from disk on load. When no vault is available, secrets are not persisted and the SSH layer prompts at connect time.