Improve remote file browser#939
Open
Sajeeth-Wimalasuriyan wants to merge 6 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Sajeeth-Wimalasuriyan
requested review from
amokiche-amd,
drchen-amd,
tomk-amd and
vstempen
as code owners
July 17, 2026 15:10
tomk-amd
reviewed
Jul 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
tomk-amd
reviewed
Jul 20, 2026
| #include "rocprofvis_controller_ssh_bridge.h" | ||
| #include "rocprofvis_core_assert.h" | ||
|
|
||
| namespace RocProfVis |
Collaborator
There was a problem hiding this comment.
Since this whole file is being re-written, (white-space changes) please add the missing copyright lines to the top too.. and the header file: rocprofvis_controller_ssh_bridge.h
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
tomk-amd
approved these changes
Jul 20, 2026
Collaborator
|
Looks good but a lot of new magic numbers for sizing and spacing. Also it would good to extract the actual file browser dialog into its own file. |
tomk-amd
reviewed
Jul 22, 2026
Collaborator
There was a problem hiding this comment.
Only 14 lines are really changed in this file.. maybe it is the same line ending problem that Aleks saw - not sure why this is happening, as I've seen it in a few files too..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation is suboptimal this revamps the design using queues from Dipal