feat: add NFD rule docs and remove stale NodeFeatureDiscovery config (NETOP-172) (#329)#95
Merged
sajmera-pensando merged 4 commits intoJun 11, 2026
Conversation
…y config (NETOP-172) (#329) Update OpenShift installation guide to use NFD-based node selector instead of hostname. Add ready-to-apply NodeFeatureRule YAML for automatic AMD Pensando NIC detection (vendor 1dd8, PF device 1002, VF device 1003). - Add NFD rule YAML to docs for users to apply manually - Update NetworkConfig examples to use feature.node.kubernetes.io/amd-nic selector instead of kubernetes.io/hostname - Remove incorrect nodefeaturediscovery.yaml template (wrong resource type, wrong PCI IDs pointing to GPU instead of NIC) - Remove all nodefeaturediscoveries RBAC (Go markers, generated config, CSV, Helm chart) since the operator does not manage that resource - Clean up pre-delete hook Job and Makefile uninstall references Co-authored-by: Yuva Shankar <11082310+yuva29@users.noreply.github.com> Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com> # Conflicts: # bundle/manifests/amd-network-operator.clusterserviceversion.yaml # docs/openshift/installation-guide.md
Bring docs/openshift/installation-guide.md from pensando main. Includes NFD-based node selector documentation and NodeFeatureRule YAML for automatic AMD Pensando NIC detection. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
- Add missing words to .wordlist.txt (OpenShift, OLM, DTK, etc.) - Fix MD022: add blank lines around headings - Fix MD032: add blank lines around lists - Fix MD028: fix blank lines inside blockquotes - Fix MD031: add blank lines around fenced code blocks - Fix MD036: replace emphasis-as-heading with proper headings - Fix MD040: add language specifier to code block - Fix MD051: fix invalid link fragments in table of contents - Fix MD024: remove duplicate Post-Installation Verification section Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
- Add radeon, rdma, repo, sdk, tawk to .wordlist.txt - Fix MD009: remove trailing spaces - Fix MD031: add blank lines around all fenced code blocks - Fix MD032: add blank lines around all lists - Fix MD040: add language to unlabeled code blocks Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of https://github.com/pensando/network-operator/pull/329
Remove stale NodeFeatureDiscovery config that was copied from GPU operator with wrong resource type and wrong PCI IDs (GPU vendor
1002instead of NIC vendor1dd8), and clean up associated RBAC.nodefeaturediscovery.yamltemplate (wrong resource type, wrong PCI IDs)nodefeaturediscoveriesRBAC from Go markers, generated config, and Helm chartnodefeaturediscoveriesDropped from cherry-pick:
bundle/manifests/amd-network-operator.clusterserviceversion.yaml—bundle/directory does not exist on ROCm maindocs/openshift/installation-guide.md—docs/openshift/directory was never cherry-picked to ROCm (introduced in pensando PR #245)