Skip to content

CI: Fix certain GitHub CI variables#241

Merged
derobins merged 1 commit into
developfrom
rildixon/ci-fixup
Mar 27, 2026
Merged

CI: Fix certain GitHub CI variables#241
derobins merged 1 commit into
developfrom
rildixon/ci-fixup

Conversation

@riley-dixon

@riley-dixon riley-dixon commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

AIHIPFILE-160

@riley-dixon riley-dixon self-assigned this Mar 27, 2026
Copilot AI review requested due to automatic review settings March 27, 2026 17:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows to rely on the runner-provided GITHUB_* environment variables (e.g., GITHUB_REF, GITHUB_JOB, GITHUB_RUN_ID) instead of ${{ github.* }} expressions in several shell steps, primarily for deriving PR numbers, container names, and CI tags.

Changes:

  • Replace ${{ github.ref }} with ${GITHUB_REF} when computing AIS_PR_NUMBER / tags.
  • Replace ${{ github.job }} / ${{ github.run_id }} / ${{ github.base_ref }} / ${{ github.head_ref }} with GITHUB_* env vars in relevant run steps.
  • Keep existing workflow behavior while standardizing variable sourcing across workflows.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/test-ais-system.yml Use GITHUB_REF to derive AIS_PR_NUMBER for AIS system/FIO test jobs.
.github/workflows/hipfile-nvidia.yml.disabled Use GITHUB_REF to derive PR number and image tag (workflow currently disabled).
.github/workflows/build-ais.yml Use GITHUB_REF, GITHUB_RUN_ID, and GITHUB_JOB for PR/container naming in the build workflow.
.github/workflows/build-ais-nvidia.yml Use GITHUB_REF and GITHUB_JOB for PR/container naming in Nvidia build workflow.
.github/workflows/build-ais-ci-image.yml Use GITHUB_REF / GITHUB_HEAD_REF for CI image tag/label metadata.
.github/workflows/ais-ci.yml Use GITHUB_BASE_REF when fetching base ref and computing CI flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-ais-ci-image.yml Outdated
Comment thread .github/workflows/ais-ci.yml Outdated
Copilot AI review requested due to automatic review settings March 27, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ais-ci.yml Outdated
Comment thread util/docker/DOCKERFILE.ais_ci_ubuntu Outdated
@derobins
derobins merged commit 396ce8f into develop Mar 27, 2026
39 checks passed
@derobins
derobins deleted the rildixon/ci-fixup branch March 27, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants