CI: Fix certain GitHub CI variables#241
Merged
Merged
Conversation
riley-dixon
requested review from
derobins,
gaoikawa,
jordan-turbofish,
kurtmcmillan and
zbyrne
as code owners
March 27, 2026 17:35
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to rely on the runner-provided GITHUB_* environment variables (e.g., GITHUB_REF, GITHUB_JOB, GITHUB_RUN_ID) instead of ${{ github.* }} expressions in several shell steps, primarily for deriving PR numbers, container names, and CI tags.
Changes:
- Replace
${{ github.ref }}with${GITHUB_REF}when computingAIS_PR_NUMBER/ tags. - Replace
${{ github.job }}/${{ github.run_id }}/${{ github.base_ref }}/${{ github.head_ref }}withGITHUB_*env vars in relevant run steps. - Keep existing workflow behavior while standardizing variable sourcing across workflows.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-ais-system.yml | Use GITHUB_REF to derive AIS_PR_NUMBER for AIS system/FIO test jobs. |
| .github/workflows/hipfile-nvidia.yml.disabled | Use GITHUB_REF to derive PR number and image tag (workflow currently disabled). |
| .github/workflows/build-ais.yml | Use GITHUB_REF, GITHUB_RUN_ID, and GITHUB_JOB for PR/container naming in the build workflow. |
| .github/workflows/build-ais-nvidia.yml | Use GITHUB_REF and GITHUB_JOB for PR/container naming in Nvidia build workflow. |
| .github/workflows/build-ais-ci-image.yml | Use GITHUB_REF / GITHUB_HEAD_REF for CI image tag/label metadata. |
| .github/workflows/ais-ci.yml | Use GITHUB_BASE_REF when fetching base ref and computing CI flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
riley-dixon
force-pushed
the
rildixon/ci-fixup
branch
from
March 27, 2026 18:07
92c9f4c to
5372925
Compare
kurtmcmillan
approved these changes
Mar 27, 2026
derobins
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIHIPFILE-160