Remove unused PLATFORM argument from ais_add_executable()#240
Merged
Conversation
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon and
zbyrne
as code owners
March 26, 2026 23:24
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the (currently unused) PLATFORM keyword argument from the internal ais_add_executable() CMake helper and relies exclusively on the project-wide CMAKE_HIP_PLATFORM setting to select HIP platform-specific compile definitions.
Changes:
- Drop
PLATFORMfromcmake_parse_arguments()forais_add_executable(). - Remove the per-call defaulting/override logic for
arg_PLATFORM. - Switch platform conditionals to use
CMAKE_HIP_PLATFORMdirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtmcmillan
approved these changes
Mar 27, 2026
riley-dixon
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.