Skip to content

Switch default CMake build mode to RelWithDebInfo #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derobins merged 3 commits into from
Mar 24, 2026
Merged

Switch default CMake build mode to RelWithDebInfo #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310a63f
Switch default CMake build mode to RelWithDebInfo
derobins Mar 19, 2026
d819d12
Update comment
derobins Mar 19, 2026
c5f6f08
Change build type to Debug in CI
derobins Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build-ais-nvidia.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:
-DCMAKE_CXX_COMPILER="${_AIS_INPUT_CXX_COMPILER}" \
-DCMAKE_CXX_FLAGS="-Werror" \
-DCMAKE_HIP_PLATFORM=nvidia \
-DAIS_BUILD_DOCS=ON \
..
'
- name: Build hipFile for the NVIDIA platform (${{ matrix.supported_compilers }})
Expand Down Expand Up @@ -114,4 +113,4 @@ jobs:
# uses: ./.github/workflows/hipfile-nvidia.yml
# needs: build_AIS_image
# with:
# platform: ${AIS_INPUT_PLATFORM}
# platform: ${AIS_INPUT_PLATFORM}
1 change: 1 addition & 0 deletions .github/workflows/build-ais.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ jobs:
export CPACK_DEBIAN_PACKAGE_RELEASE="${JOB_DESIGNATOR}${SLES_BUILD_ID_PREFIX}${BUILD_ID}~$(source /etc/os-release && echo ${VERSION_ID})"
export CPACK_RPM_PACKAGE_RELEASE="${JOB_DESIGNATOR}${SLES_BUILD_ID_PREFIX}${BUILD_ID}"
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_COMPILER="${_AIS_INPUT_CXX_COMPILER}" \
-DCMAKE_CXX_FLAGS="-Werror" \
-DCMAKE_HIP_ARCHITECTURES="${{ env.AIS_HIP_ARCHITECTURES }}" \
Comment on lines 142 to 146

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now forces -DCMAKE_BUILD_TYPE=Debug, which means CI no longer exercises the new default build type (RelWithDebInfo). If the intent of this PR is to move builds toward RelWithDebInfo, consider either using RelWithDebInfo here as well, or only using Debug conditionally (e.g., when AIS_USE_CODE_COVERAGE is enabled) so the default behavior stays validated in CI.

Copilot uses AI. Check for mistakes.
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/hipfile-nvidia.yml.disabled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ jobs:
-DCMAKE_CXX_COMPILER=g++ \
-DCMAKE_CXX_FLAGS="-Werror" \
-DCMAKE_HIP_PLATFORM=nvidia \
-DAIS_BUILD_DOCS=ON \
-DAIS_CAPABLE_DIR=\"${ROCTMPDIR}\" \
..
"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* `AIS_BUILD_EXAMPLES` has been renamed to `AIS_INSTALL_EXAMPLES`
* `AIS_USE_SANITIZERS` now also enables the following sanitizers: integer, float-divide-by-zero, local-bounds, vptr, nullability (in addition to address, leak, and undefined). Sanitizers should also now emit usable stack trace info.
* Added check in the Fastpath/AIS backend to ensure the HIP Runtime is initialized. This avoids causing a segfault in the HIP Runtime.
* The default CMake build type was changed from `Debug` to `RelWithDebInfo`

### Removed
* The rocFile library has been completely removed and the code is now a part of hipFile.
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
# CMake version according to latest ROCm platform requirements
cmake_minimum_required(VERSION 3.21)

# Set the default build type to Debug
# Set the default CMake build type
#
# NOTE: This has to be done BEFORE the project is declared!
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
set(CMAKE_BUILD_TYPE Debug CACHE STRING "Build type")
set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "Build type")
endif()

# Set the library version in a variable so we can use
Expand Down
Loading