CI: Resolve CodeQL concerns#160
Merged
derobins merged 3 commits intoJan 20, 2026
Merged
Conversation
riley-dixon
force-pushed
the
rildixon/ci-resolve-codeql-concerns
branch
from
January 19, 2026 22:15
f84a91b to
724f0ea
Compare
riley-dixon
changed the title
CodeQL highlights using Input and Matrix variables directly as being a potential vulnerability for shell injection. Most of these could however be considered a false positives since our callable workflows all call into each other, none of which accepting external user input. To make it happy however, we will redirect these variables into the environment where they will not be re-interpreted by Bash when substituted into a shell cmd.
riley-dixon
force-pushed
the
rildixon/ci-resolve-codeql-concerns
branch
from
January 19, 2026 22:44
724f0ea to
98ff89f
Compare
Closed
Collaborator
Author
|
PR#162 was used to test that there was no adverse change made to the build_ais_ci_image workflow. Workflow run: https://github.com/ROCm/hipFile/actions/runs/21154308647?pr=160 |
riley-dixon
force-pushed
the
rildixon/ci-resolve-codeql-concerns
branch
from
January 19, 2026 23:47
b148808 to
98ff89f
Compare
riley-dixon
marked this pull request as ready for review
January 19, 2026 23:53
riley-dixon
requested review from
derobins,
gaoikawa,
jordan-turbofish and
kurtmcmillan
as code owners
January 19, 2026 23:53
Further try to harden against shell injection by wrapping use of AIS variables in double-quotes.
riley-dixon
force-pushed
the
rildixon/ci-resolve-codeql-concerns
branch
from
January 20, 2026 17:28
98ff89f to
cd83220
Compare
derobins
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves some CodeQL signals that could be considered false positives since our CI variables are not provided by external workflows. There concerns in particular are regarding potential shell injection should our callable workflows ever take in input from an external user. It recommends storing inputs in the environment rather than referencing them directly within a Bash step. We also encapsulate these instances within quotes to further try to prevent injections via substitutions.
AIHIPFILE-97