Ck tile/gemm blockscale opt - #3227
Merged
Merged
Conversation
kensclin
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
November 18, 2025 09:41
Contributor
|
@kensclin Please solve the compilation error and the merge conflict. |
kensclin
force-pushed
the
ck_tile/gemm_blockscale_opt
branch
4 times, most recently
from
November 25, 2025 02:36
e4bf959 to
689ad32
Compare
kensclin
force-pushed
the
ck_tile/gemm_blockscale_opt
branch
from
November 25, 2025 03:09
689ad32 to
818b23f
Compare
Contributor
|
@kensclin Plz solve the current CI errors. |
ThomasNing
reviewed
Dec 2, 2025
ThomasNing
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Performance profiling of the GEMM BlockScale kernel revealed a major bottleneck caused by inefficient instruction scheduling, leading to excessive pipeline bubbles/stalls and subsequent performance degradation.
Testing
The result improved from 769us -> 619us.
The improvement rate is approximately 20%.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered