[llvm-test-suite] add --rocprim option to enable rocPRIM tests#2254
Merged
jplehr merged 1 commit intoJun 15, 2026
Merged
Conversation
Introduce a data-driven library-component table mapping a long option to its CMake enable variable. The long options are registered with getopt from this table, so it is the single source of truth. --rocprim sets EXTERNAL_HIP_TESTS_ROCPRIM=ON at configure and adds the build-rocprim/ test-rocprim targets to the build and test phases. Options are additive and combine with the short flags. Further components can be added with a single table entry.
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
mhalk
approved these changes
Jun 12, 2026
mhalk
left a comment
mhalk
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Nice & expandable :)
(One nitty detail I noticed was the different prefixes.)
|
|
||
| for TestTarget in check-hip-simple check-hip-catch; do | ||
| # Base HIP test targets plus a test-<name> target per requested library. | ||
| TestTargets=(check-hip-simple check-hip-catch) |
Contributor
There was a problem hiding this comment.
Assumption: We want a distinct check versus test prefix.
Contributor
Author
There was a problem hiding this comment.
That is the case for historic reasons and needs some more coordination across llvm-test-suite, buildbots, and this script to get fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the newly introduced long-options format to add
--rocprimand enable the rocPRIM testing through LLVM test suite.Introduce a data-driven library-component table mapping a long option to its CMake enable variable. The long options are registered with getopt from this table, so it is the single source of truth. --rocprim sets EXTERNAL_HIP_TESTS_ROCPRIM=ON at configure and adds the build-rocprim/ test-rocprim targets to the build and test phases. Options are additive and combine with the short flags. Further components can be added with a single table entry.