Replace per-iteration std::async with a persistent thread pool#332
Open
saleelk wants to merge 1 commit into
Open
Replace per-iteration std::async with a persistent thread pool#332saleelk wants to merge 1 commit into
saleelk wants to merge 1 commit into
Conversation
- The executor/transfer dispatch create a fresh std::thread on every iteration via std::async, adding thread-creation overhead and jitter to the measured host time. - Introduce a persistent ThreadPool created once per RunTransfers call, with separate executor and transfer pools to avoid a nested-blocking deadlock, and a ParallelRun helper that runs unit 0 inline and farms the rest to the pool. Reduces executor-time variance on unpinned runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iteration via std::async, adding thread-creation overhead and jitter to
the measured host time.
RunTransfers call, with separate executor and transfer pools to avoid a
nested-blocking deadlock, and a ParallelRun helper that runs unit 0 inline and
farms the rest to the pool. Reduces executor-time variance on unpinned runs.
Technical Details
Test Plan
Test Result
Submission Checklist