feat(miopen): Declare MIOPEN_ENABLE_HIPDNN_WRAPPER superbuild flag#6795
Open
NolanHannaAMD wants to merge 1 commit into
Open
feat(miopen): Declare MIOPEN_ENABLE_HIPDNN_WRAPPER superbuild flag#6795NolanHannaAMD wants to merge 1 commit into
NolanHannaAMD wants to merge 1 commit into
Conversation
Add a therock_declare_flag() entry so the MIOpen HIPDNN wrapper build can be controlled through the superbuild via -DTHEROCK_FLAG_MIOPEN_ENABLE_HIPDNN_WRAPPER=ON, which forwards MIOPEN_ENABLE_HIPDNN_WRAPPER=ON into the MIOpen subproject. Defaults OFF, so normal builds stay flag-off and byte-equivalent. The libMIOpen_private.so emitted when enabled is already captured by the existing MIOpen artifact globs, so no descriptor change is needed.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE ID : ALMIOPEN-2341
Add a
MIOPEN_ENABLE_HIPDNN_WRAPPERbuild flag (default OFF) that propagates-DMIOPEN_ENABLE_HIPDNN_WRAPPER=ONto the MIOpen subproject viatherock_declare_flag(). When enabled through the superbuild knob-DTHEROCK_FLAG_MIOPEN_ENABLE_HIPDNN_WRAPPER=ON, MIOpen is built as a public wrapper (libMIOpen.so) over a private implementation library (libMIOpen_private.so), with optional runtime forwarding to hipDNN (see rocm-libraries MIOpen RFC 0001).The flag defaults OFF, so normal builds are unchanged and byte-equivalent; nothing is forwarded into MIOpen unless a build explicitly opts in. The
libMIOpen_private.soemitted when the flag is ON is already captured by the existing MIOpen artifact globs, so no artifact-descriptor change is needed.