[math-libs] Fix benchmark build on Windows for primitives libs#6794
Open
amd-hsong wants to merge 1 commit into
Open
[math-libs] Fix benchmark build on Windows for primitives libs#6794amd-hsong wants to merge 1 commit into
amd-hsong wants to merge 1 commit into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Binaries of benchmarks for primitives libraries are missing from the Window build. This PR fixes the issue.
JIRA ID: ROCM-27542
Technical Details
Benchmarks on Windows do not monitor GPUs (no amdsmi dependency). The condition of building them on Windows was coupled with
NOT TARGET amdsmi. They are now decoupled.Test Plan
CI on Windows with
THEROCK_BUILD_TESTING=ONshould now build the binaries and include them in the tarball.Test Result
Check the CI and confirm the issue is fixed.
Submission Checklist