chore(compiler): bump amd-llvm to SMP 23.11 (hotswap sync to amd-staging)#6793
Open
lamb-j wants to merge 2 commits into
Open
chore(compiler): bump amd-llvm to SMP 23.11 (hotswap sync to amd-staging)#6793lamb-j wants to merge 2 commits into
lamb-j wants to merge 2 commits into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
…ing) Bumps `compiler/amd-llvm` from `9f1cce5a` to `fb300ba55`, bringing the comgr hotswap content up to parity with amd-staging. The prior pin was behind amd-staging on comgr hotswap. These nine commits are cherry-picked on top of the current pin (amd-staging landed order): - [comgr][lit] Need gfx1250 - [Comgr] Fix hotswap-rewrite-e2e lit test - [Comgr][NFC] Disable CMake EXPORT_COMPILE_COMMANDS within HotSwap (#3015) - comgr: Use triple form of lookupTarget (#3065) - AMDGPU: add hotswap entry trampoline lit coverage (#3098) - [comgr][hotswap] Place entry-stub symbols in the trampoline pool, not .text (#3417) - [Comgr] Fix build due to missed signature update (#3454) - [comgr][hotswap] use global_prefetch_b8 for GFX1250 unclaused-VMEM entry workaround (#3496) - [comgr][hotswap] Preserve VGPR-MSB mode when splitting gfx1250 WMMAs (#3428) Each carries a `(cherry picked from ...)` provenance line. Two needed trivial resolution: #3417 dropped a whitespace-only edit to a function absent from this branch; #3496 took amd-staging's lit CHECK files. After the picks, the comgr hotswap sources, the hotswap transpiler dir, and all hotswap lit + unit tests are byte-identical to amd-staging. ISSUE ID: #6235
lamb-j
force-pushed
the
users/lambj/bump-amd-llvm-smp-23.11
branch
from
July 22, 2026 22:10
a510cff to
6d26198
Compare
ScottTodd
approved these changes
Jul 22, 2026
Contributor
Author
|
Now that the compiler-runtime tests are blocking, and we have the Comgr Gtests turned on, we should get a nice clear CI signal for a failure instead of needing to dig |
Advances compiler/amd-llvm fb300ba55 -> 8bbfd71, which drops the gfx12-5-generic RUN lines from hotswap-kernel-entry-trampoline-gfx125x.s. That variant exercises the gfx12-5-generic entry-trampoline rewrite, which needs gfx12-5-generic assembler support newer than this pin's LLVM base and returns INVALID_ARGUMENT; gfx1250 and gfx1251 pass. Unblocks the comgr build-test stage. ISSUE ID: #6235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
compiler/amd-llvmfrom9f1cce5ato8bbfd71, bringing the comgr hotswap content up to parity withamd-staging.The prior pin was behind
amd-stagingon comgr hotswap. These nine commits are cherry-picked on top of the current pin, inamd-staginglanded order:[comgr][lit] Need gfx1250[Comgr] Fix hotswap-rewrite-e2e lit test[Comgr][NFC] Disable CMake EXPORT_COMPILE_COMMANDS within HotSwapcomgr: Use triple form of lookupTargetAMDGPU: add hotswap entry trampoline lit coverage[comgr][hotswap] Place entry-stub symbols in the trampoline pool, not .text[Comgr] Fix build due to missed signature update[comgr][hotswap] use global_prefetch_b8 for GFX1250 unclaused-VMEM entry workaround[comgr][hotswap] Preserve VGPR-MSB mode when splitting gfx1250 WMMAsEach carries a
(cherry picked from ...)provenance line. Two needed trivial resolution:unpackage(), a function absent from this branch; dropped (kept HEAD)..sCHECK files; tookamd-staging's versions.After the picks, the comgr hotswap sources, the
hotswap/transpiler dir, and all hotswap lit + unit tests are byte-identical toamd-staging, with one intentional exception (follow-up commit): the gfx12-5-generic RUN lines are dropped fromhotswap-kernel-entry-trampoline-gfx125x.s. That variant exercises the gfx12-5-generic entry-trampoline rewrite, which needs gfx12-5-generic assembler support newer than this pin's LLVM base and returnsINVALID_ARGUMENT; gfx1250 and gfx1251 both pass. The coverage returns when the LLVM base advances.Not included (not hotswap)
General comgr divergence from the pin's older base —
exportmap.in(unpackage/package-entry ABI) andREADME.md(AMD_COMGR_LOG_LEVEL,AMD_COMGR_USE_EMBEDDED_LIBCXXdocs) — left out of scope.Numbering
Eleventh compiler-pin change since the ww23 weekly landed (the current pin
9f1cce5ais the tenth), so this is SMP 23.11.ISSUE ID: #6235