Skip to content

chore(compiler): bump amd-llvm to SMP 23.11 (hotswap sync to amd-staging)#6793

Open
lamb-j wants to merge 2 commits into
mainfrom
users/lambj/bump-amd-llvm-smp-23.11
Open

chore(compiler): bump amd-llvm to SMP 23.11 (hotswap sync to amd-staging)#6793
lamb-j wants to merge 2 commits into
mainfrom
users/lambj/bump-amd-llvm-smp-23.11

Conversation

@lamb-j

@lamb-j lamb-j commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps compiler/amd-llvm from 9f1cce5a to 8bbfd71, bringing the comgr hotswap content up to parity with amd-staging.

The prior pin was behind amd-staging on comgr hotswap. These nine commits are cherry-picked on top of the current pin, in amd-staging landed order:

PR Title
[comgr][lit] Need gfx1250
ROCm/llvm-project#3032 [Comgr] Fix hotswap-rewrite-e2e lit test
ROCm/llvm-project#3015 [Comgr][NFC] Disable CMake EXPORT_COMPILE_COMMANDS within HotSwap
ROCm/llvm-project#3065 comgr: Use triple form of lookupTarget
ROCm/llvm-project#3098 AMDGPU: add hotswap entry trampoline lit coverage
ROCm/llvm-project#3417 [comgr][hotswap] Place entry-stub symbols in the trampoline pool, not .text
ROCm/llvm-project#3454 [Comgr] Fix build due to missed signature update
ROCm/llvm-project#3496 [comgr][hotswap] use global_prefetch_b8 for GFX1250 unclaused-VMEM entry workaround
ROCm/llvm-project#3428 [comgr][hotswap] Preserve VGPR-MSB mode when splitting gfx1250 WMMAs

Each carries a (cherry picked from ...) provenance line. Two needed trivial resolution:

After the picks, the comgr hotswap sources, the hotswap/ transpiler dir, and all hotswap lit + unit tests are byte-identical to amd-staging, with one intentional exception (follow-up commit): the gfx12-5-generic RUN lines are dropped from hotswap-kernel-entry-trampoline-gfx125x.s. That variant exercises the gfx12-5-generic entry-trampoline rewrite, which needs gfx12-5-generic assembler support newer than this pin's LLVM base and returns INVALID_ARGUMENT; gfx1250 and gfx1251 both pass. The coverage returns when the LLVM base advances.

Not included (not hotswap)

General comgr divergence from the pin's older base — exportmap.in (unpackage/package-entry ABI) and README.md (AMD_COMGR_LOG_LEVEL, AMD_COMGR_USE_EMBEDDED_LIBCXX docs) — left out of scope.

Numbering

Eleventh compiler-pin change since the ww23 weekly landed (the current pin 9f1cce5a is the tenth), so this is SMP 23.11.

ISSUE ID: #6235

@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

…ing)

Bumps `compiler/amd-llvm` from `9f1cce5a` to `fb300ba55`, bringing the
comgr hotswap content up to parity with amd-staging.

The prior pin was behind amd-staging on comgr hotswap. These nine
commits are cherry-picked on top of the current pin (amd-staging landed
order):

- [comgr][lit] Need gfx1250
- [Comgr] Fix hotswap-rewrite-e2e lit test
- [Comgr][NFC] Disable CMake EXPORT_COMPILE_COMMANDS within HotSwap (#3015)
- comgr: Use triple form of lookupTarget (#3065)
- AMDGPU: add hotswap entry trampoline lit coverage (#3098)
- [comgr][hotswap] Place entry-stub symbols in the trampoline pool, not
  .text (#3417)
- [Comgr] Fix build due to missed signature update (#3454)
- [comgr][hotswap] use global_prefetch_b8 for GFX1250 unclaused-VMEM
  entry workaround (#3496)
- [comgr][hotswap] Preserve VGPR-MSB mode when splitting gfx1250 WMMAs
  (#3428)

Each carries a `(cherry picked from ...)` provenance line. Two needed
trivial resolution: #3417 dropped a whitespace-only edit to a function
absent from this branch; #3496 took amd-staging's lit CHECK files. After
the picks, the comgr hotswap sources, the hotswap transpiler dir, and all
hotswap lit + unit tests are byte-identical to amd-staging.

ISSUE ID: #6235
@lamb-j
lamb-j force-pushed the users/lambj/bump-amd-llvm-smp-23.11 branch from a510cff to 6d26198 Compare July 22, 2026 22:10
@lamb-j

lamb-j commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Now that the compiler-runtime tests are blocking, and we have the Comgr Gtests turned on, we should get a nice clear CI signal for a failure instead of needing to dig

Advances compiler/amd-llvm fb300ba55 -> 8bbfd71, which drops the
gfx12-5-generic RUN lines from hotswap-kernel-entry-trampoline-gfx125x.s.
That variant exercises the gfx12-5-generic entry-trampoline rewrite, which
needs gfx12-5-generic assembler support newer than this pin's LLVM base and
returns INVALID_ARGUMENT; gfx1250 and gfx1251 pass. Unblocks the comgr
build-test stage.

ISSUE ID: #6235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants