ci: clarify PyTorch build dispatch inputs and default the ROCm index#6791
Open
ethanwee1 wants to merge 1 commit into
Open
ci: clarify PyTorch build dispatch inputs and default the ROCm index#6791ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
Manual dispatches of the multi-arch PyTorch build workflows commonly
fail in two ways:
- `repository`/`ref` are mistaken for the PyTorch source, so people
point them at rocm/pytorch. The outer checkout then grabs the wrong
repo and every TheRock build script is "No such file or directory".
- `rocm_package_index_url`/`rocm_package_find_links_url` are left
blank, so `rocm[libraries,devel]` resolves against PyPI (only a
placeholder 0.1.0 exists) instead of the ROCm nightlies index.
Clarify the `repository`/`ref` and ROCm index/find-links input
descriptions (which repo, which URL, use one OR the other), and default
`rocm_package_index_url` on the Linux portable workflow_dispatch path to
the nightly multi-arch index so a bare manual build works. The
workflow_call defaults are left untouched so programmatic callers that
pass find-links are unaffected.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
ethanwee1
marked this pull request as ready for review
July 22, 2026 21:53
ScottTodd
reviewed
Jul 22, 2026
Comment on lines
111
to
+125
| rocm_package_find_links_url: | ||
| description: URL for pip --find-links to install ROCm packages (flat page; use this OR rocm_package_index_url) | ||
| description: >- | ||
| URL for pip --find-links to install ROCm packages (flat page). Use | ||
| this OR rocm_package_index_url, not both. If you set this, clear | ||
| rocm_package_index_url (otherwise both get passed to pip). | ||
| type: string | ||
| default: "" | ||
| rocm_package_index_url: | ||
| description: URL for pip --index-url to install ROCm packages (PEP 503 index, e.g. repo.amd.com; use this OR rocm_package_find_links_url) | ||
| description: >- | ||
| URL for pip --index-url to install ROCm packages (PEP 503 index). | ||
| Defaults to the nightly multi-arch index; override to build against a | ||
| different ROCm channel or a specific build's index. Use this OR | ||
| rocm_package_find_links_url, not both. | ||
| type: string | ||
| default: "" | ||
| default: "https://rocm.nightlies.amd.com/whl-multi-arch" |
Member
There was a problem hiding this comment.
"If you set this, clear (some other variable)" doesn't work with inputs that have a default. If you set to empty string then github will revert back to the default.
See here for example:
TheRock/.github/workflows/multi_arch_release.yml
Lines 74 to 79 in 29faf3b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6790
What
Manual dispatches of the multi-arch PyTorch build workflows commonly fail in two avoidable ways. This PR makes the inputs self-explanatory and gives the Linux path a sane default.
repository/refmistaken for the PyTorch source. They select which TheRock checkout the build scripts come from. When set torocm/pytorch, the outer checkout grabs the wrong repo and every step fails withbuild_tools/github_actions/*.py: No such file or directory(shown as the misleading "Executing the custom container implementation failed").rocm_package_index_urlandrocm_package_find_links_urlblank makespip install rocm[libraries,devel]==<nightly>resolve against PyPI, whererocmis only a placeholder0.1.0, so the pinned nightly can't be found.Changes
repository/refdescriptions on both build workflows: they refer to TheRock (build scripts/workflow), not the PyTorch source; usepytorch_git_refto pick the PyTorch branch.rocm_package_index_urlon the Linux portableworkflow_dispatchpath to the nightly multi-arch index (https://rocm.nightlies.amd.com/whl-multi-arch) so a bare manual build works.workflow_calldefaults are intentionally left unchanged, so programmatic callers (release/CI wrappers, some of which passfind-links) are unaffected.Windows keeps an empty ROCm-URL default (its packages are not served from the Linux multi-arch index), but its input descriptions get the same clarifications.
Test
pre-commit(incl. actionlint) passes on both workflow files.workflow_dispatchmetadata;workflow_callbehavior is unchanged.