fix: Fix command injection vulnerability in upload_package_repo.py#6789
Open
raramakr wants to merge 1 commit into
Open
fix: Fix command injection vulnerability in upload_package_repo.py#6789raramakr wants to merge 1 commit into
raramakr wants to merge 1 commit into
Conversation
…0354) Refactor run_command() to prevent shell injection attacks: - Accept list[str] instead of string commands with shell=True - Add stdout parameter for file redirects instead of shell redirection - Add type hints and docstring Additional improvements: - Add encoding="utf-8" to all text file operations - Convert os.path usage to pathlib.Path for consistency
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
nunnikri
reviewed
Jul 22, 2026
nunnikri
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Lets complete the ci run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor run_command() to prevent shell injection attacks:
Additional improvements:
JIRA ID: https://amd-hub.atlassian.net/browse/ROCM-26880