ci(wsl-rocdxg): move most WSLENV into common job-level env#6781
Open
dysu-amd wants to merge 3 commits into
Open
ci(wsl-rocdxg): move most WSLENV into common job-level env#6781dysu-amd wants to merge 3 commits into
dysu-amd wants to merge 3 commits into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
dysu-amd
marked this pull request as ready for review
July 22, 2026 21:12
Contributor
Author
|
@ScottTodd @amd-chiranjeevi Is there a way I could test out these changes in a 'release' context? |
Member
You can trigger a dev release using workflow_dispatch here: https://github.com/ROCm/TheRock/actions/workflows/multi_arch_release.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move most definitions of
WSLENVinto a common job-level variable as suggested in https://github.com/ROCm/TheRock/pull/6764/changes#r3632422006Might have prevented #6763 from happening.
Technical Details
WSLENVand move their values to the job-levelWSLENVdefinitionTHEROCK_WIN_SDK_SHAREDis able to be specified in job-levelWSLENV, even though it is defined in a runtime step.WSLENVis parsed by WSL at runtime, so it is able to pick up the SDK path without issues as long asenv: THEROCK_WIN_SDK_SHARED: ...is set for each step that requires it.WSLENVat the step level.Configure AWS credentialsstep. Before this step is run, they are empty.Fetch inbound artifacts, which runs beforeConfigure, will read the empty envs and try to pull from an empty S3 URL, so they cannot be set before this step is run.WSLENVand instead append them in any steps that require them.env: WSLENV: ${{ env.WSLENV }}:...allows appending toWSLENVrather than overwriting it.Test Plan
Test Result
Dev release workflow in progress: https://github.com/ROCm/TheRock/actions/runs/29964916475
Submission Checklist