Skip to content

ci(wsl-rocdxg): move most WSLENV into common job-level env#6781

Open
dysu-amd wants to merge 3 commits into
mainfrom
users/danielsu/common-wslenv
Open

ci(wsl-rocdxg): move most WSLENV into common job-level env#6781
dysu-amd wants to merge 3 commits into
mainfrom
users/danielsu/common-wslenv

Conversation

@dysu-amd

@dysu-amd dysu-amd commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Motivation

Move most definitions of WSLENV into a common job-level variable as suggested in https://github.com/ROCm/TheRock/pull/6764/changes#r3632422006

Might have prevented #6763 from happening.

Technical Details

  • Removed most step-level definitions of WSLENV and move their values to the job-level WSLENV definition
    • THEROCK_WIN_SDK_SHARED is able to be specified in job-level WSLENV, even though it is defined in a runtime step.
      • WSLENV is parsed by WSL at runtime, so it is able to pick up the SDK path without issues as long as env: THEROCK_WIN_SDK_SHARED: ... is set for each step that requires it.
      • Added comments to the three steps using the SDK var
  • The AWS credential envs cannot be set for the whole job, so append them to WSLENV at the step level.
    • The AWS envs are set during the Configure AWS credentials step. Before this step is run, they are empty.
    • Fetch inbound artifacts, which runs before Configure, will read the empty envs and try to pull from an empty S3 URL, so they cannot be set before this step is run.
    • Therefore we don't set them in job-level WSLENV and instead append them in any steps that require them.
    • env: WSLENV: ${{ env.WSLENV }}:... allows appending to WSLENV rather than overwriting it.

Test Plan

  • WSL CI workflow passes
  • WSL release workflow passes

Test Result

Dev release workflow in progress: https://github.com/ROCm/TheRock/actions/runs/29964916475

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 22, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 22, 2026
@dysu-amd dysu-amd changed the title [TEST] ci(wsl-rocdxg): move all WSLENV into common job-level env ci(wsl-rocdxg): move all WSLENV into common job-level env Jul 22, 2026
@dysu-amd
dysu-amd marked this pull request as ready for review July 22, 2026 21:12
@dysu-amd

Copy link
Copy Markdown
Contributor Author

@ScottTodd @amd-chiranjeevi Is there a way I could test out these changes in a 'release' context?

@dysu-amd dysu-amd changed the title ci(wsl-rocdxg): move all WSLENV into common job-level env ci(wsl-rocdxg): move most WSLENV into common job-level env Jul 22, 2026
@ScottTodd

Copy link
Copy Markdown
Member

@ScottTodd @amd-chiranjeevi Is there a way I could test out these changes in a 'release' context?

You can trigger a dev release using workflow_dispatch here: https://github.com/ROCm/TheRock/actions/workflows/multi_arch_release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants