doc: install rust 1.95#6779
Open
amd-arosa wants to merge 1 commit into
Open
Conversation
amd-arosa
requested review from
ScottTodd and
marbre
and removed request for
marbre
July 22, 2026 16:16
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
therock-pr-bot
Bot
removed
the
Not ready to Review
ScottTodd
reviewed
Jul 22, 2026
ScottTodd
left a comment
ScottTodd
left a comment
Member
There was a problem hiding this comment.
I edited more details into the PR description.
- You can remove fields from the template that aren't applicable like "test plan" for docs changes
- PRs by definition close themselves, text like
Closes #6779to satisfy the PR policy bot are invalid. This PR does actually address #6418, so I added a link to that instead
Comment on lines
+201
to
+208
| > winget install --id Rustlang.Rustup --exact --source winget | ||
| > # Open a new terminal before running the remaining commands. | ||
| > rustup install 1.95 | ||
| > ``` | ||
|
|
||
| Rust 1.95 and Cargo are general build dependencies. The `rustup` installation | ||
| provides both tools. Open a new terminal after installation if `rustup`, | ||
| `rustc`, or `cargo` is not immediately available on `PATH`. |
Member
There was a problem hiding this comment.
Source builds of Mirage are not currently enabled on Windows. Do you still want to add this requirement here?
Lines 822 to 827 in 0f2827e
Comment on lines
+20
to
+47
| ## Required Build Toolchains | ||
|
|
||
| ### Rust 1.95 | ||
|
|
||
| Rust 1.95 and Cargo are general build dependencies on Linux and Windows. Install | ||
| the required toolchain with [`rustup`](https://rustup.rs/). | ||
|
|
||
| On Linux: | ||
|
|
||
| ```bash | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \ | ||
| sh -s -- --default-toolchain 1.95.0 | ||
| source "$HOME/.cargo/env" | ||
| rustc --version | ||
| cargo --version | ||
| ``` | ||
|
|
||
| On Windows: | ||
|
|
||
| ```powershell | ||
| winget install --id Rustlang.Rustup --exact --source winget | ||
| # Open a new terminal before running the remaining commands. | ||
| rustup install 1.95 | ||
| rustc --version | ||
| cargo --version | ||
| ``` | ||
|
|
||
| If `rustup` is already installed, only `rustup install 1.95` is needed. |
Member
There was a problem hiding this comment.
Documentation like this should go below Reference Build Environments, not above it. The reference build environments are containers that already have all prerequisites included.
Comment on lines
110
to
+115
| # Install dependencies following the Windows support guide | ||
|
|
||
| # Install Rust and Cargo through rustup | ||
| winget install --id Rustlang.Rustup --exact --source winget | ||
| # Open a new terminal before running the remaining commands. | ||
| rustup install 1.95 |
Member
There was a problem hiding this comment.
Omit from here
- "Install dependencies following the Windows support guide" already covers other deps (like MSVC), rust is not worth calling out on its own here
- Rust is not currently used on Windows anyways?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Submission Checklist