fix(ci): Re-enable amd-smi static for gfx1151 in CI sanity check#6778
Open
darren-amd wants to merge 1 commit into
Open
fix(ci): Re-enable amd-smi static for gfx1151 in CI sanity check#6778darren-amd wants to merge 1 commit into
darren-amd wants to merge 1 commit into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
|
unit tests not needed, this is enabling testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2789
The CI "Driver / GPU sanity check" skips
amd-smi staticforgfx1151because the command used to hang and time out on gfx1151 (tracked in #2789).amd-smi staticno longer times out on gfx1151, so the skip can be removed to restore sanity-check coverage on that family.Technical Details
gfx1151was the only remaining entry inunsupported_amdsmi_familiesinbuild_tools/print_driver_gpu_info.py. Rather than leave an empty list, this removes the list, theAMDGPU_FAMILIESenv read, and the now-dead conditional (and itsTODO(#2789)) entirely, soamd-smi staticalways runs on Linux.Test Plan
Verified on a gfx1151 machine by running
amd-smi staticandAMDGPU_FAMILIES=gfx1151 python3 ./build_tools/print_driver_gpu_info.pybefore and after the change.Test Result
amd-smi staticcompletes in ~0.1s with no timeout. The sanity script now runs theamd-smi staticsection end-to-end for gfx1151 with no errors, and the default (unsetAMDGPU_FAMILIES) path still works.Submission Checklist