Skip to content

fix(ci): Re-enable amd-smi static for gfx1151 in CI sanity check#6778

Open
darren-amd wants to merge 1 commit into
mainfrom
users/darren-amd/enable-amdsmi-static-gfx1151
Open

fix(ci): Re-enable amd-smi static for gfx1151 in CI sanity check#6778
darren-amd wants to merge 1 commit into
mainfrom
users/darren-amd/enable-amdsmi-static-gfx1151

Conversation

@darren-amd

Copy link
Copy Markdown
Contributor

Motivation

Closes #2789

The CI "Driver / GPU sanity check" skips amd-smi static for gfx1151 because the command used to hang and time out on gfx1151 (tracked in #2789). amd-smi static no longer times out on gfx1151, so the skip can be removed to restore sanity-check coverage on that family.

Technical Details

gfx1151 was the only remaining entry in unsupported_amdsmi_families in build_tools/print_driver_gpu_info.py. Rather than leave an empty list, this removes the list, the AMDGPU_FAMILIES env read, and the now-dead conditional (and its TODO(#2789)) entirely, so amd-smi static always runs on Linux.

Test Plan

Verified on a gfx1151 machine by running amd-smi static and AMDGPU_FAMILIES=gfx1151 python3 ./build_tools/print_driver_gpu_info.py before and after the change.

Test Result

amd-smi static completes in ~0.1s with no timeout. The sanity script now runs the amd-smi static section end-to-end for gfx1151 with no errors, and the default (unset AMDGPU_FAMILIES) path still works.

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/print_driver_gpu_info.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 22, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@marifamd

Copy link
Copy Markdown
Contributor

unit tests not needed, this is enabling testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

[Issue] amd-smi static command is not enabled for Linux gfx1151 see stuck issue on CI

2 participants