Enable PyTorch release/2.13 in release and CI build matrices#6746
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
Resolve UNSUPPORTED_AMDGPU_FAMILIES conflict: keep main's gfx90c exclusions and re-enabled gfx1250 for release/2.12 & nightly (#6735); add release/2.13 excluding gfx125X-dcgpu (no 2.13 gfx1250 support yet) and gfx90c.
therock-pr-bot
Bot
removed
the
Not ready to Review
| def test_release_2_13_filters_gfx125x(self): | ||
| matrix = m.generate_pytorch_matrix_for_release_type( | ||
| release_type="dev", | ||
| python_versions=["3.12"], | ||
| pytorch_git_refs=["release/2.13"], | ||
| amdgpu_families="gfx94X-dcgpu;gfx125X-dcgpu", | ||
| platform="linux", | ||
| ) | ||
|
|
||
| # gfx125X-dcgpu not yet enabled on the release/2.13 ref, should filter. | ||
| self.assertEqual( | ||
| matrix, | ||
| [ | ||
| { | ||
| "python_version": "3.12", | ||
| "pytorch_git_ref": "release/2.13", | ||
| "amdgpu_families": "gfx94X-dcgpu", | ||
| } | ||
| ], | ||
| ) |
There was a problem hiding this comment.
This test case looks very similar to test_filters_exact_unsupported_family just above. Could merge the two.
(developers and agents should resist the tempation to just endlessly append new unit tests whenever changing code, the existing tests should be made robust enough to cover future behavior changes too)
There was a problem hiding this comment.
Good call — merged it into test_filters_exact_unsupported_family, which now uses subTest to cover every ref that excludes gfx125X-dcgpu (release/2.10 and release/2.13). Dropped the near-duplicate test_release_2_13_filters_gfx125x. Done in 38c1958.
Address review feedback: test_release_2_13_filters_gfx125x duplicated test_filters_exact_unsupported_family. Merge them into a single subTest-parametrized test that covers every ref currently excluding gfx125X-dcgpu (release/2.10 and release/2.13), so future refs are exercised by the existing test instead of a new near-duplicate.
| # out while supported families (gfx94X-dcgpu) are kept. Covers every | ||
| # ref that currently excludes gfx125X-dcgpu so new refs are exercised | ||
| # here rather than in a separate near-duplicate test. |
There was a problem hiding this comment.
The comment here is likely to go stale (another thing to watch for with coding agents - they like to inject details from discussion into code comments)
2 participants
Closes #6792
What
Enable PyTorch
release/2.13across TheRock's release and CI build matrices, matching howrelease/2.10–2.12are wired:release/2.13toRELEASE_STABLE_PYTORCH_REFS(linux + windows) andCI_PYTORCH_REFS(linux) inconfigure_pytorch_release_matrix.py.release/2.13toDEFAULT_PYTORCH_GIT_REFSingenerate_pytorch_source_manifest.py.gfx125X-dcgpuunsupported forrelease/2.13(not yet upstreamed to pytorch/pytorch; see [issue] gfx1250 pytorch build temporary env vars #5833).external-builds/pytorch/README.md(downstream ROCm/pytorchrelease/2.13).configure_pytorch_release_matrix_test.py/configure_multi_arch_ci_test.py.