Skip to content

Add docs popup#129

Merged
GyuH13 merged 1 commit into
mainfrom
feature-docs-popup
Jun 1, 2026
Merged

Add docs popup#129
GyuH13 merged 1 commit into
mainfrom
feature-docs-popup

Conversation

@GyuH13

@GyuH13 GyuH13 commented Jun 1, 2026

Copy link
Copy Markdown
Member

Add popup that notices robotis docs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new DocsMigrationNotice component to notify users that the AI Worker documentation has moved to ROBOTIS Docs, and integrates it into the VitePress theme layout. Feedback on these changes includes wrapping localStorage access in a try-catch block to prevent potential crashes in SSR or restricted environments, using the user's local date instead of UTC to avoid timezone-related dismissal issues, and extending the default VitePress theme using the extends property rather than object spreading.

Comment thread docs/.vitepress/theme/components/DocsMigrationNotice.vue
Comment thread docs/.vitepress/theme/components/DocsMigrationNotice.vue
Comment thread docs/.vitepress/theme/index.js
@GyuH13
GyuH13 requested a review from sunghowoo June 1, 2026 06:52

@sunghowoo sunghowoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunghowoo
sunghowoo requested a review from nhw-robotis June 1, 2026 07:23

@nhw-robotis nhw-robotis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@GyuH13
GyuH13 merged commit e0656a3 into main Jun 1, 2026
1 check passed
@GyuH13
GyuH13 deleted the feature-docs-popup branch June 1, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants