-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/see source values (STIT-493) #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ece3ccf
PLAN
AlexAxthelm 46b02d6
Expose source priority in resource view
AlexAxthelm f932989
Add UI elements in front end for field source details
AlexAxthelm 1bd0705
Add demo resource
AlexAxthelm 8bf056a
Update UI
AlexAxthelm 7e3a2fb
Improve API, expose new endpoint for interrogating source composition
AlexAxthelm d83d3a0
Remove PLAN
AlexAxthelm b1934a1
style: format
AlexAxthelm b30fa05
Merge branch 'main' into feat/see-source-values
AlexAxthelm ca99267
code review: guards and formatting
AlexAxthelm 4d41ddf
Use correct cache key
AlexAxthelm f7151b1
Use correct cache key
AlexAxthelm 9cf46e2
Avoid dangling aria-controls
AlexAxthelm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| [ | ||
| { | ||
| "id": 0, | ||
| "source_data": [ | ||
| { | ||
| "source": "rmi", | ||
| "name": "Coalescing Demo Field", | ||
| "country": "USA", | ||
| "location_type": "Onshore", | ||
| "discovery_year": 1969 | ||
| }, | ||
| { | ||
| "source": "gem", | ||
| "name": "Coalescing Demo (GEM A)", | ||
| "country": "USA", | ||
| "basin": "Permian Basin", | ||
| "latitude": 31.9, | ||
| "longitude": -102.1, | ||
| "production_conventionality": "Unconventional", | ||
| "discovery_year": 1970, | ||
| "production_start_year": 1975 | ||
| }, | ||
| { | ||
| "source": "gem", | ||
| "name": "Coalescing Demo (GEM B)", | ||
| "country": "CAN", | ||
| "basin": "Williston Basin", | ||
| "production_conventionality": "Conventional", | ||
| "discovery_year": 1971 | ||
| }, | ||
| { | ||
| "source": "wm", | ||
| "name": "Coalescing Demo (WM)", | ||
| "country": "GBR", | ||
| "basin": "North Sea", | ||
| "state_province": "Texas", | ||
| "latitude": 31.85, | ||
| "longitude": -102.2, | ||
| "location_type": "Offshore", | ||
| "primary_hydrocarbon_group": "Light Oil", | ||
| "discovery_year": 1968, | ||
| "production_start_year": 1974, | ||
| "field_status": "Producing" | ||
| }, | ||
| { | ||
| "source": "llm", | ||
| "name": "Coalescing Demo (LLM)", | ||
| "country": null, | ||
| "basin": "Ghawar (guess)", | ||
| "primary_hydrocarbon_group": "Medium Oil", | ||
| "field_status": "Non-Producing" | ||
| } | ||
| ], | ||
| "constituents": [] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a separate endpoint? The
OGFieldDetailViewalready has a full list of sources, sorted in priority order. Could we drop the extra API call & endpoint if we use that data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a finer grained endpoint, since we'll need to move away from the idea that a resource only has a single set of priorities, and to the idea that each field has its own set of priorities (so the priorities for "Basin" and "Local name" may be differently ordered).
To that end, I think dropping the full list of sources from the OGFieldDetailView is probably a good call moving forward (or at least don't imply that it's an ordered set), and if we need source details, we can fetch those as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we drop the full list of sources, then the Detail view becomes just the ListItemView and forces us to make calls for every field attribute the user wants to view. Any other service will need to do the same to get the full, equivalent data for a Field.