Point denorm_generators_eia at out_eia__yearly_generators (re #527)#529
Open
steps-re wants to merge 1 commit into
Open
Point denorm_generators_eia at out_eia__yearly_generators (re #527)#529steps-re wants to merge 1 commit into
steps-re wants to merge 1 commit into
Conversation
PUDL removed the intermediate _out_eia__yearly_generators table a few releases ago; the same data now lives in out_eia__yearly_generators (which this file already references elsewhere). Update the two remaining stale references in utils/pudl.py and utils/table_map.py. Re RMI#527. Signed-off-by: Mike German <mike@stepsventures.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #527.
PUDL removed the intermediate
_out_eia__yearly_generatorstable a few releases back; the same data is now published asout_eia__yearly_generators. This updates the two remaining stale references:src/etoolbox/utils/pudl.py- thepl_scan_pudl(...)call ingenerator_ownershipsrc/etoolbox/utils/table_map.py- thedenorm_generators_eiamappingThe new name is already used elsewhere in
table_map.py(e.g.mcoe_generators_yearly), so this just brings the two stragglers in line.I scoped this deliberately to the one table called out in the issue. There are other leading-underscore
_out_eia__*entries intable_map.py(capacity factor, heat rate, fuel cost, plants_utilities, etc.), but some intermediate tables legitimately keep the_out_prefix, so I didn't want to rename them blind. If it'd help, point me at the current PUDL table list (or confirm which were promoted) and I'm happy to audit and fix the rest in a follow-up.Verified locally: package imports fine,
ruffclean, and the unit suite passes (the only errors are a pre-existing missingscript_runnerfixture, identical on a clean checkout).