Skip to content

sys/include: use SPDX license tags [n]#22477

Open
kfessel wants to merge 6 commits into
RIOT-OS:masterfrom
kfessel:p-spdx-include-n
Open

sys/include: use SPDX license tags [n]#22477
kfessel wants to merge 6 commits into
RIOT-OS:masterfrom
kfessel:p-spdx-include-n

Conversation

@kfessel

@kfessel kfessel commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Contribution description

This took #21908 and has just [n] (mostly 'net') to avoid too many files Github issues (part 2/3)

#22475 got Licenses and may be (or not) merged first

Testing procedure

check diff for correctness
@maribu did when creating the original @kfessel does while creating this before switching it from draft

Issues/PRs references

#21515 tracking issue
#22476 [a-m]
#22477 [n]
#22478 [o-z]
#21908 original
#22475 Licenses
#22324 another one has given up

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • none

@github-actions github-actions Bot added Area: network Area: Networking Area: BLE Area: Bluetooth Low Energy support Area: LoRa Area: LoRa radio support Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels Jul 15, 2026
@AnnsAnns AnnsAnns added the AI: None Stated AI was not (stated to be) used in this PR/Issue label Jul 15, 2026
* we set our DTLS endpoint to use DTLS version 1.2 and act as a DTLS server.
*
* Note that some DTLS implementation do not support earlier versions of DTLS.
* In this case, @ref sock_dtls_create() will return an error. A list of

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in line 689

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnsAnns are you able to guess why these reference errors happen?
other references (same file work fine)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had good luck with removing the () AFAIR.

@kfessel kfessel marked this pull request as ready for review July 15, 2026 15:22
@kfessel kfessel requested a review from maribu as a code owner July 15, 2026 15:22
@kfessel

kfessel commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

i published this PR even though there are reference errors with doxygen since the actual changes are probably unrelated

@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 15, 2026
@riot-ci

riot-ci commented Jul 15, 2026

Copy link
Copy Markdown

Murdock results

✔️ PASSED

143eb0f f:tools/doccheck: adjust exclud_simple line-numbers

Success Failures Total Runtime
1 0 1 01m:17s

Artifacts

Comment thread sys/include/net/gnrc/sixlowpan/frag.h Outdated
* we set our DTLS endpoint to use DTLS version 1.2 and act as a DTLS server.
*
* Note that some DTLS implementation do not support earlier versions of DTLS.
* In this case, @ref sock_dtls_create() will return an error. A list of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had good luck with removing the () AFAIR.

Comment thread sys/include/net/gcoap.h
* This file is subject to the terms and conditions of the GNU Lesser
* General Public License v2.1. See the file LICENSE in the top level
* directory for more details.
* SPDX-FileCopyrightText: 2015-2017 Ken Bannister. All rights reserved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* SPDX-FileCopyrightText: 2015-2017 Ken Bannister. All rights reserved.
* SPDX-FileCopyrightText: 2015-2017 Ken Bannister

Vermutlich nicht notwendig.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to not change that

Co-authored-by: crasbe <crasbe@gmail.com>
@kfessel

kfessel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

I had good luck with removing the () AFAIR.

did not work this time and there are more of these reference issues the static test is pointing to (no ())
i think its probably a doxygen roll a dice for more errors-issue

shall i just add the filter?

@kfessel

kfessel commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

ahh i see that doxygen f-up was there before and also before it was just painted over

dist/tools/doccheck/exclude_simple
8387:sys/include/net/sock/dodtls.h:135: warning: unable to resolve reference to 'sock_dtls_create()' for \ref command
8388:sys/include/net/sock/dtls.h:36: warning: unable to resolve reference to 'sock_dtls_create()' for \ref command
8389:sys/include/net/sock/dtls.h:46: warning: unable to resolve reference to 'sock_dtls_create()' for \ref command
8390:sys/include/net/sock/dtls.h:267: warning: unable to resolve reference to 'sock_dtls_create()' for \ref command
8392:sys/include/net/sock/dtls.h:1110: warning: unable to resolve reference to 'sock_dtls_create()' for \ref command

so i just need to paint over again for this pr

seems like i need to update #22327

@kfessel kfessel force-pushed the p-spdx-include-n branch from 729c115 to b1eb66d Compare July 16, 2026 11:12
@github-actions github-actions Bot added the Area: tools Area: Supplementary tools label Jul 16, 2026
boards/msbiot/doc.md:73: warning: unable to resolve reference to 'LED1_ON' for \ref command
boards/msbiot/doc.md:73: warning: unable to resolve reference to 'LED1_OFF' for \ref command
boards/msbiot/doc.md:73: warning: unable to resolve reference to 'LED1_TOGGLE' for \ref command
sys/include/net/gnrc/netif/pktq/type.h:12: warning: Potential recursion while resolving \ref command!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line moved up an became L9

at fist i though this was a doublet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: None Stated AI was not (stated to be) used in this PR/Issue Area: BLE Area: Bluetooth Low Energy support Area: CoAP Area: Constrained Application Protocol implementations Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: sys Area: System Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants