net/unicoap: Unified and Modular CoAP Stack: Minimal Client (pt 3)#22266
net/unicoap: Unified and Modular CoAP Stack: Minimal Client (pt 3)#22266carl-tud wants to merge 25 commits into
Conversation
mguetschow
left a comment
There was a problem hiding this comment.
First round of review, mostly typos and nitpicks. I couldn't find the promised client tutorial and the example might benefit from further comments as you did for the server example.
Otherwise: Great work, as always!
|
Hey @carl-tud, thank you for your contribution to RIOT! Please note that we require for all PRs to RIOT a declaration of AI-Tools / LLMs usage. It appears as if this section is missing in your PR. Please copy and fill in the section from .github/PULL_REQUEST_TEMPLATE.md. Thank you! |
| /** | ||
| * @brief Tries to find client state object based on reference number | ||
| * |
There was a problem hiding this comment.
you could mark this as being feature-gated behind the CONFIG_CANCELLABLE flag
| @@ -246,7 +233,6 @@ int unicoap_uri_populate(uri_parser_result_t *parsed, unicoap_endpoint_t *endpoi | |||
| tl_ep->family = AF_INET; | |||
| static_assert(sizeof(tl_ep->addr.ipv4) == sizeof(v4->u8), | |||
| "Programmer error: IPv5 size mismatch"); | |||
| .buffer = buffer, | ||
| .capacity = buffer_capacity | ||
| }; | ||
| mutex_init_locked(&args.roadblock); |
There was a problem hiding this comment.
There is also MUTEX_INIT_LOCKED that you could use directly in the initializer
This PR is the third in a series to introduce
unicoap, a unified and modular CoAP implementation for RIOT. An overview of all PRs related tounicoapis presented in #21389, including reasons whyunicoapis needed and a performance analysis.What does this PR include?
The new API is more flexible. CoAP resource addresses are abstracted into a
unicoap_destination_tstructure and transport-specific settings are controlled by flags. For example, this is how you can send a request to aI'll organise the monolithic commit into multiple structured commits once this has passed review, and rebase this PR onto #21582 once merged.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are:
nada, niente