net/unicoap: Unified and Modular CoAP Stack: Messaging and Minimal Server (pt 2)#21582
Conversation
da014c7 to
4d00949
Compare
|
@LasseRosenow RIOT/sys/include/net/unicoap/transport.h Lines 344 to 355 in 4d00949 |
mguetschow
left a comment
There was a problem hiding this comment.
Thanks for the next PR! Great code quality as usual! Reviewed up to and including unicoap/docs.
crasbe
left a comment
There was a problem hiding this comment.
A first look-through. Mikolai already commented about the indentation of the preprocessor commands, but I only saw that once I went through it 😅
There are probably some functions that slipped through, but I'll do a second round when most of the comments are resolved. It's becoming a bit crowded.
mguetschow
left a comment
There was a problem hiding this comment.
Now this is (only?) missing review of */transport.c, server.c, and state.c.
|
One test datapoint: |
9a0b4e3 to
9bb6179
Compare
adf3a6d to
534a07b
Compare
IETF Hackathon unicoap testing party resultstested with ✅ means the test passed successfully, ❌ means the test did not pass, in case of (❌) it is most likely not unicoap's fault
notes:
TL;DR:
|
mguetschow
left a comment
There was a problem hiding this comment.
After the last round of successful tests, let's gooooo!
same |
534a07b to
9424aa5
Compare
diff --git a/examples/networking/coap/unicoap_message/Makefile.ci b/examples/networking/coap/unicoap_message/Makefile.ci
index 3dfb5c722c..54417567ab 100644
--- a/examples/networking/coap/unicoap_message/Makefile.ci
+++ b/examples/networking/coap/unicoap_message/Makefile.ci
@@ -1,8 +1,10 @@
BOARD_INSUFFICIENT_MEMORY := \
arduino-duemilanove \
+ arduino-leonardo \
arduino-nano \
arduino-uno \
atmega328p \
atmega328p-xplained-mini \
atmega8 \
+ nucleo-l011k4 \
#diff --git a/examples/networking/coap/unicoap_server/Makefile.ci b/examples/networking/coap/unicoap_server/Makefile.ci
index d3841a2374..fa8fdaf917 100644
--- a/examples/networking/coap/unicoap_server/Makefile.ci
+++ b/examples/networking/coap/unicoap_server/Makefile.ci
@@ -1,5 +1,4 @@
BOARD_INSUFFICIENT_MEMORY := \
- airfy-beacon \
arduino-duemilanove \
arduino-leonardo \
arduino-mega2560 \
@@ -13,18 +12,15 @@ BOARD_INSUFFICIENT_MEMORY := \
blackpill-stm32f103c8 \
bluepill-stm32f030c8 \
bluepill-stm32f103c8 \
- calliope-mini \
derfmega128 \
hifive1 \
hifive1b \
i-nucleo-lrwan1 \
im880b \
mega-xplained \
- microbit \
microduino-corerf \
msb-430 \
msb-430h \
- nrf51dongle \
nucleo-c031c6 \
nucleo-f030r8 \
nucleo-f031k6 \
@@ -34,6 +30,7 @@ BOARD_INSUFFICIENT_MEMORY := \
nucleo-f302r8 \
nucleo-f303k8 \
nucleo-f334r8 \
+ nucleo-g031k8 \
nucleo-l011k4 \
nucleo-l031k6 \
nucleo-l053r8 \
@@ -44,6 +41,8 @@ BOARD_INSUFFICIENT_MEMORY := \
saml11-xpro \
slstk3400a \
stk3200 \
+ stm32c0116-dk \
+ stm32c0316-dk \
stm32f030f4-demo \
stm32f0discovery \
stm32f7508-dk \
@@ -52,7 +51,6 @@ BOARD_INSUFFICIENT_MEMORY := \
stm32mp157c-dk2 \
telosb \
weact-g030f6 \ |
This PR is the second in a series to introduce
unicoap, a unified and modular CoAP implementation for RIOT. An overview of all PRs related tounicoapis presented in #21389, including reasons whyunicoapis needed and a performance analysis.What does this PR include?
unicoapon a thread of your choice, e.g., the main thread.The new API is more flexible. CoAP endpoints are abstracted into a
unicoap_endpoint_tstructure and transport-specific settings are controlled by flags. For example, this is a simple resource that responds with "Hello, World!".More in the documentation (CI build sometimes not available, e.g., due to failing tests).
Open discussion points
why does Github not allow to see all unresolved comments and/or to pin comments?!?
listed in #21582 (comment)
Declaration of AI-Tools / LLMs usage:
actual intelligence