dist/tools/cosy: provide patch for PR #13#18343
Merged
Merged
Conversation
The upstream PR RIOT-OS#13 is not yet merged but fixes classification to no longer classify most of RIOT's object files "unspecified" in the `.text` view.
maribu
added
Type: bug
miri64
approved these changes
Jul 20, 2022
miri64
left a comment
miri64
left a comment
Member
There was a problem hiding this comment.
ACK. Can confirm that this fixes the problem: I tried to run BOARD=iotlab-m3 make -C examples/gnrc_networking cosy -j on both master () and for this PR. On master, all but newlib symbols are categorized as unspecified. With this patch, it is sorted into the appropriate directories. With native there are still some unspecified symbols, but I don't think this has anything to do with what this patch is trying to accomplish.
miri64
added
CI: skip compile test
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The upstream PR #13 is not yet merged but fixes classification to no
longer classify most of RIOT's object files "unspecified" in the
.textview.Since @Jnae authored the fix, I added her as author in the commit adding the patch to not steal credit.
Testing procedure
make cosywith a recent should now give sensible output. I can confirm that it fixes the issue for me.Apparently on @benpicco 's machine it worked before. Maybe he can confirm it doesn't break anything.
Issues/PRs references
Upstream PR: haukepetersen/cosy#13
Implementation of @leandrolanzieri suggestion: https://forum.riot-os.org/t/suggestions-for-measuring-memory-usage/3666/7