fix: add complete Darwin Core annotations - #465
Conversation
|
Thanks Les - looks like we've run the label/description extraction on http://rs.tdwg.org/dwc/terms.ttl which doesn't have all the labels (just the one), are you able to find if there's an rdf source for them all? I can see each term has it's own RDF under a version. http://rs.tdwg.org/dwc/terms/version/eventTime-2025-06-12.ttl Ideally there's a single RDF source we can strip all the labels/descriptions from |
|
For the failing check, the PR title needs to be a conventional commit https://www.conventionalcommits.org/en/v1.0.0/#summary So something like "fix: add missing dwc labels" |
yes, I wasn't sure if the workflow was 'just get the whole ontology' or not. We're not sure if there is such a canonical RDF version of DWC at this stage. Have added the labels to bdr vocabs repo instead dcceew-bdr/bdr-vocabs@7426e42 - will move this PR back to draft pending further investigation. |
|
Hi @recalcitrantsupplant , managed to fetch all DWC labels now - proposed file is on this branch. |
|
Is the preflabel / label and comment / definition duplication intentional? Would be good to have one or the other |
not really motivated. What's best? looks like many annotation files here use rdfs:label and schema:description only, although some don't feature the latter (maybe not available from the sources). Happy to fix however fits best. |
|
Ah, they're duplicated at source Another issue I see is prez uses skos:definition and dcterms:description as "descriptive properties" but in DWC here they are both used and have different content. Could you decide which you think is better and drop the other, or, if you think we should make an enhancement in Prez to support three annotation fields (label / definition / description) then we should open another issue for this. " description_predicates: list = [ |
Fixed now, all have only:
|
|
🎉 This PR is included in version 4.23.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Not sure about using language tags for labels and descriptions, there seems to be a bit of inconsistency across the repo - not sure if that's normalised in downstream systems (for ref, these additions arrive out of an audit for the Biodiversity Data Repository https://github.com/dcceew-bdr/bdr-ops/issues/217).