Skip to content

fix: add complete Darwin Core annotations - #465

Merged
recalcitrantsupplant merged 3 commits into
mainfrom
add-dwc-class-annotations
Jul 20, 2026
Merged

fix: add complete Darwin Core annotations#465
recalcitrantsupplant merged 3 commits into
mainfrom
add-dwc-class-annotations

Conversation

@leskneebone

Copy link
Copy Markdown
Collaborator

Not sure about using language tags for labels and descriptions, there seems to be a bit of inconsistency across the repo - not sure if that's normalised in downstream systems (for ref, these additions arrive out of an audit for the Biodiversity Data Repository https://github.com/dcceew-bdr/bdr-ops/issues/217).

@leskneebone leskneebone self-assigned this Jun 9, 2026
@recalcitrantsupplant

Copy link
Copy Markdown
Collaborator

Thanks Les - looks like we've run the label/description extraction on http://rs.tdwg.org/dwc/terms.ttl which doesn't have all the labels (just the one), are you able to find if there's an rdf source for them all? I can see each term has it's own RDF under a version. http://rs.tdwg.org/dwc/terms/version/eventTime-2025-06-12.ttl

Ideally there's a single RDF source we can strip all the labels/descriptions from

@recalcitrantsupplant

Copy link
Copy Markdown
Collaborator

For the failing check, the PR title needs to be a conventional commit https://www.conventionalcommits.org/en/v1.0.0/#summary

So something like "fix: add missing dwc labels"

@leskneebone

Copy link
Copy Markdown
Collaborator Author

Thanks Les - looks like we've run the label/description extraction on http://rs.tdwg.org/dwc/terms.ttl which doesn't have all the labels (just the one), are you able to find if there's an rdf source for them all? I can see each term has it's own RDF under a version. http://rs.tdwg.org/dwc/terms/version/eventTime-2025-06-12.ttl

Ideally there's a single RDF source we can strip all the labels/descriptions from

yes, I wasn't sure if the workflow was 'just get the whole ontology' or not. We're not sure if there is such a canonical RDF version of DWC at this stage.

Have added the labels to bdr vocabs repo instead dcceew-bdr/bdr-vocabs@7426e42 - will move this PR back to draft pending further investigation.

@leskneebone
leskneebone marked this pull request as draft June 9, 2026 07:10
@leskneebone leskneebone changed the title Add Darwin Core class annotations fix: add complete Darwin Core annotations Jul 20, 2026
@leskneebone
leskneebone marked this pull request as ready for review July 20, 2026 01:29
@leskneebone

Copy link
Copy Markdown
Collaborator Author

Hi @recalcitrantsupplant , managed to fetch all DWC labels now - proposed file is on this branch.

@recalcitrantsupplant

Copy link
Copy Markdown
Collaborator

Is the preflabel / label and comment / definition duplication intentional? Would be good to have one or the other

@leskneebone

Copy link
Copy Markdown
Collaborator Author

Is the preflabel / label and comment / definition duplication intentional? Would be good to have one or the other

not really motivated. What's best? looks like many annotation files here use rdfs:label and schema:description only, although some don't feature the latter (maybe not available from the sources). Happy to fix however fits best.

@recalcitrantsupplant

Copy link
Copy Markdown
Collaborator

Ah, they're duplicated at source
I would say drop one or the other. Perhaps just keep SKOS (prefLabel + definition)

Another issue I see is prez uses skos:definition and dcterms:description as "descriptive properties" but in DWC here they are both used and have different content. Could you decide which you think is better and drop the other, or, if you think we should make an enhancement in Prez to support three annotation fields (label / definition / description) then we should open another issue for this.

" description_predicates: list = [
SKOS.definition,
DCTERMS.description,
SDO.description,
]"

@leskneebone

Copy link
Copy Markdown
Collaborator Author

Ah, they're duplicated at source I would say drop one or the other. Perhaps just keep SKOS (prefLabel + definition)

Another issue I see is prez uses skos:definition and dcterms:description as "descriptive properties" but in DWC here they are both used and have different content. Could you decide which you think is better and drop the other, or, if you think we should make an enhancement in Prez to support three annotation fields (label / definition / description) then we should open another issue for this.

" description_predicates: list = [ SKOS.definition, DCTERMS.description, SDO.description, ]"

Fixed now, all have only:

  • One rdfs:label
  • One skos:definition

@recalcitrantsupplant recalcitrantsupplant left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@recalcitrantsupplant
recalcitrantsupplant merged commit 421ee0a into main Jul 20, 2026
4 checks passed
@recalcitrantsupplant
recalcitrantsupplant deleted the add-dwc-class-annotations branch July 20, 2026 03:08
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.23.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants