feat: double-underscore env var convention for hyphenated config keys#402
Merged
Conversation
The legacy FOGWALL_ env var mapping (single _ → .) cannot represent hyphenated config keys such as providers.gitea-ssh.api-token, because env var names cannot contain hyphens. Adopt the double-underscore convention used by systemd/Docker/k8s: within the path portion (after the FOGWALL_ prefix), __ maps to . and _ maps to -. This is activated only when __ appears in the name, so all existing single-underscore vars continue to work unchanged. FOGWALL_PROVIDERS__GITEA_SSH__API_TOKEN → providers.gitea-ssh.api-token FOGWALL_SECRET_SCAN__ENABLED → secret-scan.enabled FOGWALL_SERVER_PORT (legacy) → server.port (unchanged) Adds unit tests for envVarToConfigPath() covering both conventions. closes #386 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
coopernetes
force-pushed
the
feat/env-var-hyphen-fix
branch
from
44243bb to
2e1cc75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FOGWALL_env var overrides so hyphenated config keys can be targetedFOGWALL_),__maps to.and_maps to-; activated only when__appears in the nameExamples
Test plan
envVarToConfigPath()cover both conventions and hyphenated top-level keys./gradlew :fogwall-server:test :fogwall-server:jacocoTestCoverageVerification --rerunpassescloses #386