fix: historic lookback for resting heart rate data#203
Open
pvannierop wants to merge 1 commit into
Open
Conversation
pvannierop
force-pushed
the
fix/fitbit-resting-heart-rate-historic-lookback
branch
from
4feb439 to
bf640b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The historic lookback mechanism ensures that after a certain timeperiod (14 days by default) a missing datum will be considered to be never present. After this period, the datum will never be queried again.
Problem
For Fitbit Resting Heart Rate this mechanism was never invoked. Instead of passing the end date of the current request to the underlying code, NOW is always passed. This ensures the underlying code never considers the missing datum to expire.
Solution
Inline with other FitbitRoute classes the end of the current request is passed to the underlying code.