refactor(asgi): drop ASGI bridge; OxyRoute 0.3.0 is RSGI-only - #89
Merged
Conversation
OxyRoute v0.3.0 supports a single transport (RSGI). The runtime ASGI compatibility bridge in oxyroute/asgi.py is removed: - delete oxyroute/asgi.py - drop App.__call__, App._asgi3 = build_asgi_caller(self), and the websocket / _handle_asgi_websocket plumbing from oxyroute/app.py - delete the ASGI-only test suites (test_asgi*, test_websocket_asgi) The unit/integration tests still drive the app in-process through httpx.ASGITransport for speed and isolation, so the same bridge code moves to tests/_rsgi_test_transport.py as a *test fixture only* and each affected test now does ``httpx.ASGITransport(app=asgi_test_app(app))``. Refs #88.
OxyRoute v0.3.0 only supports RSGI; the ASGI compatibility bridge and the ASGI websocket spike were removed. Documentation is updated to match: - delete docs/asgi.md and docs/websocket.md - remove the ASGI bridge entry from docs/index.md and the cross-link from docs/http2.md - README: drop the optional ASGI bullet and the "ASGI and other servers are covered..." paragraph; project layout no longer mentions an "optional ASGI bridge" - docs/rsgi.md: drop the "When to use ASGI instead" section - docs/feature.md: mark ASGI compatibility as removed and reflect the new WebSocket status (native RSGI WS upcoming) - docs/sse.md / docs/dependencies.md / docs/development.md: refer to the in-process httpx test transport instead of the removed bridge Refs #88.
Reflect the breaking removal of the ASGI bridge: - pyproject.toml / Cargo.toml / Cargo.lock / oxyroute.__version__ / src/state.rs OpenAPI version → 0.3.0. - Add CHANGELOG.md with a 0.3.0 entry describing the dropped ASGI surface (App.__call__, oxyroute.asgi, ASGI-based @app.websocket) and the test-time migration to tests/_rsgi_test_transport.asgi_test_app. Refs #88.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxyroute/asgi.py),App.__call__,App._asgi3, and the ASGI-based@app.websocket(path)/_handle_asgi_websocketplumbing. RSGI is the only supported transport from v0.3.0.tests/test_asgi*,tests/test_websocket_asgi.py) and migrate the rest of the suite to the new in-process shimtests/_rsgi_test_transport.asgi_test_app(app)so existing httpx-driven tests keep working without leaking ASGI back into the package.docs/asgi.mdanddocs/websocket.md; updateREADME.md,docs/index.md,docs/rsgi.md,docs/feature.md,docs/sse.md,docs/dependencies.md,docs/development.md,docs/http2.mdto remove ASGI references and reflect the new transport story.0.3.0(pyproject.toml,Cargo.toml,oxyroute.__version__,src/state.rsOpenAPI) and add aCHANGELOG.mdwith a breaking-change entry plus migration notes.Test plan
cargo checkmake testCloses #88.