perf(asgi): remove per-request fresh event-loop creation - #83
Merged
Conversation
Replace per-request asyncio.run loop creation with a lazily initialized thread-local loop to reduce ASGI bridge fixed overhead under load.
Add regression coverage that fails if the blocking bridge path reintroduces per-request asyncio.run, with explicit loop cleanup for test hygiene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.runin the ASGI blocking bridge with a reused thread-local event loopasyncio.runis used again on the blocking pathTest plan
uv run pytest tests/test_asgi_internals.py tests/test_asgi_stress.py tests/test_asgi.pyBenchmark notes
_run_handle_rsgi_blockingCloses #73