You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verified — this does everything we need. I built our production wasm-bindgen wrapper (parses raw API JSON into Post/Reply, discovers URLs via Thread::icons() + image_urls(), feeds caller-fetched bytes as InternedImages into to_epub_from_images) against this branch with zero source changes, ran it over a real thread with all icons interned, and the output epub is byte-identical to what our production build (from #65) serves. Keeping the async api/intern_images path alive on wasm via reqwest's fetch backend is a nicer design than my module gating, and the .cargo/config.toml rustflags are a good touch.
Happy to see this merged in place of #65 — and if it makes it to a crates.io release, we can drop our vendored copy entirely. Thanks for picking it up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.