NA-0677 (D-0012): the infra-literal gate and advisories - #41
Merged
Conversation
THE INTENT SAID "PORT THE SPINE'S PUBLIC-SAFETY JOB". THERE WAS NOTHING TO PORT. That job scans for private keys and cloud tokens; it has never contained an address, path or host pattern -- which is exactly why it ran green on every pull request that published a private LAN address. The failure was the pattern set, not the scan's scope. scripts/ci/infra_literal_scan.py is that missing set. The scanner is BYTE-IDENTICAL to the copies in qsl-desktop, qsl-server and qsl-protocol (cmp-proven). The pattern set is deliberately NOT forked. TIERS. Tier 1 over the whole tracked tree; Tier 2b over added lines only; Tier 2a not scanned. This repo is TIER-1 CLEAN at landing: 39 files, 13,391 lines, zero hits. The private names are salted SHA-256 digests, not text: this repo is public, and a pattern file naming them would republish what the sanitize lane removed AND make the Tier-1 scan hit its own pattern file. The plaintext list is operator-held. Matching is TOKEN-WISE, so a name embedded in an identifier is caught while one merely spanning a camelCase seam is not. ADVISORIES: --deny warnings with NO waiver file -- this repo's dependency graph is clean today. If that changes the fix is a NAMED-ID waiver, never dropping --deny warnings. CLIPPY IS UNCHANGED: this repository already ran clippy --all-targets -D warnings. It is the only one of the four that did, and it needed nothing. ⚠ BOTH NEW JOBS ARE ADVISORY, NOT BLOCKING. This repo requires exactly one context, `rust`, which is unchanged. ⚠ Note also that this repo has enforce_admins: false where the other three have true -- observed during the lane's census, REPORTED AND NOT ACTED ON (outside D613's scope, operator's call). PROVED BY POSITIVE CONTROL IN THIS REPOSITORY, not inherited from the file. Evidence: /srv/qbuild/evidence/NA-0677/gate_positive_control.txt fmt, clippy --all-targets and cargo audit --deny warnings all clean. Spine D613, lane NA-0677.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: G4
The intent said "port the spine's public-safety job". There was nothing to port. That job scans for private keys and cloud tokens; it has never contained an address, path or host pattern — which is exactly why it ran green on every pull request that published a private LAN address. The failure was the pattern set, not the scan's scope.
scripts/ci/infra_literal_scan.pyis that missing pattern set.The scanner is byte-identical to the copies in the other three repositories (
cmp-proven at landing). The pattern set is deliberately not forked: one source of truth for one question.Proved in THIS repository, not inherited from the file
A gate is a property of the repo it runs in, not of the script. The embedded-literal control was run here:
SOME_<name>_THINGin a tracked file/srv/qbuild/evidence/NA-0677/gate_positive_control.txt.Design
Tiers. Tier 1 (network-identifying + personal identity) over the whole tracked tree. Tier 2b (low-frequency private names) over added lines only. Tier 2a (build-root and home paths) not scanned — the citation convention adds them to ~60% of governance commits, so a gate on them would be switched off within a week.
The private names are salted SHA-256 digests, not text. This repository is public: a pattern file naming them would republish what the sanitize lane removed — and the Tier-1 scan would then hit its own pattern file. The plaintext list is operator-held. Matching is token-wise (non-alphanumerics and camelCase transitions), so a name embedded in an identifier is caught while one merely spanning a camelCase seam is not.
The scan reports what it examined —
clean (tree; N files, M lines examined)— and refuses to report a pass over an empty input in tree and diff modes, because a green indistinguishable from a no-op is the defect this gate exists to answer.⚠ These jobs are ADVISORY, not blocking
This repository requires exactly one status context,
rust, which is unchanged.public-safetyandadvisoriesrun and report but cannot block a merge until they are added to the required set — the operator's act. Green is not the same as blocking.🤖 Generated with Claude Code
This repo: Tier-1 clean at landing (39 files, 13,391 lines, zero hits).
cargo audit --deny warningspasses with no waiver file. Clippy is unchanged — this repository already ran--all-targets, the only one of the four that did, and it needed nothing.⚠ Observed and not acted on: this repository has
enforce_admins: falsewhere the other three havetrue. Noted during the lane's census; outside D613's scope and the operator's decision.No-regression: fmt,
clippy --all-targets -D warningsandcargo audit --deny warningsall clean;git diff --checkclean; the gate returns clean on this PR in both--mode treeand--mode staged; no product source changed.