fix: Correctly create pyarrow dictionary for enums#344
Open
Oliver Borchert (borchero) wants to merge 1 commit into
Open
fix: Correctly create pyarrow dictionary for enums#344Oliver Borchert (borchero) wants to merge 1 commit into
Oliver Borchert (borchero) wants to merge 1 commit into
Conversation
Oliver Borchert (borchero)
requested review from
Andreas Albert (AndreasAlbertQC) and
Daniel Elsner (delsner)
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3427 3427
=========================================
Hits 3427 3427 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the project to test against Polars v1.41 and adjusts Enum’s PyArrow schema mapping to match Polars’ Arrow export semantics for enums.
Changes:
- Bump
feature.polars-latestfrom1.39.*to1.41.*(and refreshpixi.lockaccordingly). - Create PyArrow dictionary types for
Enumcolumns withordered=True.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pixi.toml |
Updates the “latest” Polars feature pin to 1.41.*. |
pixi.lock |
Regenerates the lockfile to reflect the updated Polars versions across environments/platforms. |
dataframely/columns/enum.py |
Sets ordered=True when building the PyArrow dictionary dtype for Enum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nightly CI for the just-released polars v1.41 uncovered a bug.