Skip to content

fix: distinguish pending broker orders from executions - #379

Merged
Pigbibi merged 2 commits into
mainfrom
fix/ibkr-order-outcome-truth
Aug 24, 2026
Merged

fix: distinguish pending broker orders from executions#379
Pigbibi merged 2 commits into
mainfrom
fix/ibkr-order-outcome-truth

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Classifies IBKR non-terminal order states as pending reconciliation rather than execution success.
  • Retains broker order IDs in telemetry and reconciliation records.
  • Renders pending buy and sell confirmations distinctly in notifications.
  • Preserves execution deduplication while a broker order awaits a final state.
  • Blocks new buys and top-ups when the strategy explicitly flags the account below its recommended minimum; strategy-driven reductions remain allowed.

Validation

  • Execution, rebalance and notification tests: 70 passed.
  • Request-handling and runtime-broker-adapter tests: 55 passed; 3 existing warnings.
  • Ruff check passed for all changed files.

Pigbibi and others added 2 commits August 24, 2026 12:42
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit d93dcc5 into main Aug 24, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/ibkr-order-outcome-truth branch August 24, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant