Add non-trading Cloud Run warmup scheduler - #342
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /healthzat the configuredprobe_time2retries, bounded backoff)/runscheduler retry policy unchangedIncident addressed
Two active US services returned HTTP 500 while Cloud Run was starting a new instance. No strategy execution report or order submission was observed. The warmup moves cold-start work before the trading scheduler without making live execution retryable.
Validation
uv run pytest -q tests/test_cloud_run_warmup_workflow.py tests/test_cloud_run_runtime_guard.py tests/test_reconcile_cloud_runtime.py— 17 passeduv run ruff check .— passedactionlint .github/workflows/sync-cloud-run-env.yml— passedgit diff --check— passedFull
uv run pytest -q: 309 passed, 5 skipped, 11 pre-existing failures in unrelated runtime/test-drift areas. This PR changes only the env-sync workflow and its static contract test.Safety boundary
/run