Skip to content

fix: distinguish Firstrade submissions from fills - #252

Merged
Pigbibi merged 2 commits into
mainfrom
fix/firstrade-pending-reconciliation
Aug 24, 2026
Merged

fix: distinguish Firstrade submissions from fills#252
Pigbibi merged 2 commits into
mainfrom
fix/firstrade-pending-reconciliation

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Why

A live Firstrade submit response acknowledges the order but does not prove a fill. The runtime currently treats it as action_done and persists a submitted terminal stage.

Change

  • retain submitted orders for audit and cash controls
  • expose broker_submission_done, pending_reconciliation, and pending order count
  • persist PENDING_RECONCILIATION rather than a completed action
  • keep previewed and explicitly filled outcomes distinct

Dependency

Merge PR 251 first; it restores the GCS create-only primitive used by the existing live claim.

Verification

  • targeted execution-service, rebalance-service, and live-claim tests passed
  • git diff whitespace check passed

Pigbibi and others added 2 commits August 24, 2026 15:21
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the fix/firstrade-pending-reconciliation branch from 151ef69 to c2ef809 Compare August 24, 2026 07:21
@Pigbibi
Pigbibi merged commit b696e22 into main Aug 24, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/firstrade-pending-reconciliation branch August 24, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant