chore(deps): align QPK pin to f0d6bc739943 - #80
Conversation
Automated downstream QPK pin update after QPK_PIN landed on main. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d51f870db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requires-python = ">=3.11" | ||
| dependencies = [ | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84", |
There was a problem hiding this comment.
This bumps the installable QuantPlatformKit revision, but qsl.toml still advertises the old 2381aa... requirement. The repo has an explicit governance check in tests/test_contract_governance.py::test_qpk_dependency_matches_lock_and_compat_metadata asserting that this exact pyproject dependency appears in qsl["compat"]["requires"], so this change leaves CI failing and causes downstream compatibility metadata to report a different QPK revision than the package actually installs.
Useful? React with 👍 / 👎.
| requires-python = ">=3.11" | ||
| dependencies = [ | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f0d6bc7399433b9a1ccdaab1f0874faf184cfa84", |
There was a problem hiding this comment.
This line pins QPK to the merge commit f0d6bc..., but the CI workflow's Check QPK pin and lock consistency step runs QPK's checker against external/QuantPlatformKit/QPK_PIN; at this upstream revision that source-of-truth file contains de18c2..., not f0d6bc.... Even after the compat metadata is synchronized, the checker will still reject pyproject.toml and uv.lock for referencing a QPK SHA different from the canonical pin.
Useful? React with 👍 / 👎.
|
Superseded: downstream pin sync must update qsl.toml compatibility metadata together with pyproject.toml and uv.lock. |
1 participant
Summary
f0d6bc739943uv.lock，同步刷新 lockfileTest plan
🤖 Generated with Claude Code