fix: make missing PR review backend opt-in advisory - #15
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
c2df65e to
804e899
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2df65ec13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| repository: ${{ inputs.bridge_repository || 'QuantStrategyLab/AIAuditBridge' }} | ||
| ref: ${{ inputs.bridge_ref || 'main' }} |
There was a problem hiding this comment.
For reusable callers that pin this workflow to a SHA/tag, or for reruns after main has advanced, this now checks out the runner script from AIAuditBridge@main unless every caller passes bridge_ref. That means the executed Python no longer matches the trusted workflow revision being invoked and can unexpectedly run newer code with the inherited GitHub/API tokens; it also breaks the existing tests/test_run_codex_pr_review.py::CodexPrReviewWorkflowTest expectation that the bridge checkout follows job.workflow_repository/job.workflow_sha. Default this checkout back to the called workflow/base commit, and only override it explicitly when needed.
Useful? React with 👍 / 👎.
804e899 to
32dfdf4
Compare
Pigbibi
changed the title
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
32dfdf4 to
dd5c515
Compare
Pigbibi
changed the title
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32dfdf4eec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if _review_backend_is_unconfigured(exc): | ||
| print("::warning::Codex review backend is not configured; leaving human-review note without failing the workflow.") | ||
| return 0 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Co-Authored-By: Codex <noreply@openai.com>
dd5c515 to
b92e244
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
Summary\n- add an explicit reusable-workflow input for caller repos that do not configure an AI review backend\n- keep the default behavior fail-closed for high-risk review infrastructure errors\n- only turn an unconfigured backend into a human-review note when the caller opts in\n\n## Verification\n- actionlint .github/workflows/*.yml\n- python3 -m ruff check .\n- python3 -m pytest tests -q\n- node --test cloudflare/codex-audit-proxy/tests/index.test.mjs\n- node --test cloudflare/ai-gateway-dash/tests/index.test.mjs